You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/30 02:46:42 UTC

[GitHub] [spark] Yikun commented on a diff in pull request #36712: [SPARK-39326][PYTHON][PS] replace "NaN" with real "None" value in indexes

Yikun commented on code in PR #36712:
URL: https://github.com/apache/spark/pull/36712#discussion_r884381079


##########
python/pyspark/pandas/frame.py:
##########
@@ -551,11 +551,11 @@ def ndim(self) -> int:
         >>> df = ps.DataFrame([[1, 2], [4, 5], [7, 8]],
         ...                   index=['cobra', 'viper', None],
         ...                   columns=['max_speed', 'shield'])
-        >>> df
+        >>> df  # doctest: +SKIP

Review Comment:
   The fix will be failed with panda 1.3.x (it's [current version of ci infra](https://github.com/dongjoon-hyun/ApacheSparkGitHubActionImage/blob/ac09d7a4431b209caa86090c54bfccd4d744d0ce/Dockerfile#L32)), as I mentioned in [previous comment](https://github.com/apache/spark/pull/36712#issuecomment-1140234328) , we will cleanup `# doctest: +SKIP` after we upgrade pandas to 1.4.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org