You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by hsaputra <gi...@git.apache.org> on 2014/07/08 09:52:07 UTC

[GitHub] incubator-flink pull request: [FLINK-1007] Clean up and refactor o...

GitHub user hsaputra opened a pull request:

    https://github.com/apache/incubator-flink/pull/64

    [FLINK-1007] Clean up and refactor on Scala and Java code

    First cleanup attempt, mostly on Scala code, to follow guidelines from http://docs.scala-lang.org/style:
    
    1. Remove return statement from Scala code where it is not necessary (end of method definition)
    2. Remove extra semicolon (;) from Scala and Java code
    3. First drop to abide to 100 chars per line for Scala code.
       Will send another PR for other files as I have encountered.
    4. Remove parentheses for empty argument methods that do not have side effect
       (see http://www.artima.com/pins1ed/composition-and-inheritance.html#i1343251059-1)
    5. Remove unused import statements in Scala code as I have encountered them.
    
    This is first drop to refactor and clean up Scala code to see comment/ response from community.
    Additional PRs for follow up code will come as needed.
    
    Comments and suggestions are welcomed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hsaputra/incubator-flink cleanup_code_part_one

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-flink/pull/64.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #64
    
----
commit b3a988df44722a84741d7bac68a48b9816202d79
Author: Henry Saputra <hs...@apache.org>
Date:   2014-07-08T07:38:46Z

    First cleanup attempt, mostly on Scala code, to follow guidelines from http://docs.scala-lang.org/style:
    1. Remove return statement from Scala code where it is not necessary (end of method definition)
    2. Remove extra ; from Scala and Java code
    3. First drop to abide to 100 chars per line for Scala code.
       Will send another PR for other files as I have encountered.
    4. Remove parentheses for empty argument methods that do not have side effect
       (see http://www.artima.com/pins1ed/composition-and-inheritance.html#i1343251059-1)
    5. Remove unused import statements in Scala code as I have encountered them.
    
    This is first drop to refactor and clean up Scala code to see comment/ response from community.
    More PRs for follow up code will come.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-flink pull request: [FLINK-1007] Clean up and refactor o...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-flink/pull/64


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---