[GitHub] [flink] Myasuka commented on a diff in pull request #19142: [FLINK-23252][changelog] Support recovery from checkpoint after disab…

[GitBox <gi...@apache.org>]

Myasuka commented on code in PR #19142:
URL: https://github.com/apache/flink/pull/19142#discussion_r847160050


##########
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogStateBackend.java:
##########
@@ -75,27 +77,37 @@
 
     private final StateBackend delegatedStateBackend;
 
+    private final boolean forSwitch;

Review Comment:
   How about renamed to `restoreAndSwitchOnly`?
   
   Naming is a hard thing.



##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/metadata/MetadataV2V3SerializerBase.java:
##########
@@ -391,7 +394,7 @@ static void serializeKeyedStateHandle(KeyedStateHandle stateHandle, DataOutputSt
             dos.writeLong(handle.getStateSize());
             dos.writeLong(handle.getCheckpointedSize());
             writeStateHandleId(handle, dos);
-
+            dos.writeUTF(handle.getStorageIdentifier());

Review Comment:
   Why we must introduce a storage identifier here to initialize the change log storage?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org