You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by Jochen Kemnade <jo...@eddyson.de> on 2015/08/14 15:32:19 UTC
TAP5-2414
Hi,
we should address this before 5.4 final. "Address" could mean "close as
invalid" of course, but we should make a decision.
Jochen
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: TAP5-2414
Posted by Jochen Kemnade <jo...@eddyson.de>.
Hi,
Am 14.08.2015 um 17:27 schrieb Thiago H de Paula Figueiredo:
> Question: what additions were done from the 5.3 XSD to the 5.4 one? If
> none, we could just say that a workaround is to use the 5.3 XSD in 5.4
> applications, as the code attempts to only apply this check when using
> the 5.4 DTD.
If no xsd is specified in the component template, we use the latest one,
don't we? So explicitly specifying the 5.3 one might indeed be the
correct solution for TAP5-2414.
> On the other hand, the line at
> https://github.com/apache/tapestry-5/commit/1f0c7464c80e415a19825c612ca6b8139db6ba1e#diff-b953a076427d6d267140c53c9ca98d73R743
> seems to have it logic reversed:
>
> if (version.sameOrEarlier(T_5_4)) {
> strictMixinParameters = true;
> }
>
That was fixed one commit later. ;-)
Jochen
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: TAP5-2414
Posted by Thiago H de Paula Figueiredo <th...@gmail.com>.
On Fri, 14 Aug 2015 10:32:19 -0300, Jochen Kemnade
<jo...@eddyson.de> wrote:
> Hi,
Hi!
> we should address this before 5.4 final. "Address" could mean "close as
> invalid" of course, but we should make a decision.
Question: what additions were done from the 5.3 XSD to the 5.4 one? If
none, we could just say that a workaround is to use the 5.3 XSD in 5.4
applications, as the code attempts to only apply this check when using the
5.4 DTD. On the other hand, the line at
https://github.com/apache/tapestry-5/commit/1f0c7464c80e415a19825c612ca6b8139db6ba1e#diff-b953a076427d6d267140c53c9ca98d73R743
seems to have it logic reversed:
if (version.sameOrEarlier(T_5_4)) {
strictMixinParameters = true;
}
It goes against this comment in ComponentTemplate:
"In strict mode, introduced with the 5.4 template DTD, mixin parameters
must be qualified with the mixin name.
In prior releases, Tapestry would attempt a search for a fit, and this
causes ambiguities
that can't be addressed."
--
Thiago H. de Paula Figueiredo
Tapestry, Java and Hibernate consultant and developer
http://machina.com.br
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org