You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/02/11 20:21:33 UTC

[GitHub] [couchdb] davisp commented on a change in pull request #2540: Use multi-transactional iterators

davisp commented on a change in pull request #2540: Use multi-transactional iterators
URL: https://github.com/apache/couchdb/pull/2540#discussion_r377872657
 
 

 ##########
 File path: src/fabric/include/fabric2.hrl
 ##########
 @@ -57,7 +57,10 @@
 -define(PDICT_TX_ID_KEY, '$fabric_tx_id').
 -define(PDICT_TX_RES_KEY, '$fabric_tx_result').
 -define(PDICT_ON_COMMIT_FUN, '$fabric_on_commit_fun').
+-define(PDICT_FOLD_ACC_STATE, '$fabric_fold_acc_state').
+
 -define(COMMIT_UNKNOWN_RESULT, 1021).
+-define(TRANSACTION_TOO_OLD, 1007).
 
 Review comment:
   Super minor nit, but should we order by error code and make a comment as such? Seems like it might be easier to match between other definitions of these in fdb/erlang bindings and such.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services