[jira] [Commented] (KAFKA-3836) KStreamReduce and KTableReduce should not pass nulls to Deserializers

["Guozhang Wang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15330066#comment-15330066 ] 

Guozhang Wang commented on KAFKA-3836:
--------------------------------------

Example places that we should guard against null values: when reading from state stores returns null, it means no such key-value pair exist yet, and hence we should skip calling deserialization and return null directly.

> KStreamReduce and KTableReduce should not pass nulls to Deserializers
> ---------------------------------------------------------------------
>
>                 Key: KAFKA-3836
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3836
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>    Affects Versions: 0.10.0.0
>            Reporter: Avi Flax
>            Assignee: Guozhang Wang
>            Priority: Trivial
>
> As per [this discussion|http://mail-archives.apache.org/mod_mbox/kafka-users/201606.mbox/%3cCAHwHRrU29jw4jgVhSijWbVLZB3BC6Qz6pbH9TqCFBcoRJk4aZQ@mail.gmail.com%3e] these classes currently pass null values along to Deserializers, so those Deserializers need to handle null inputs and pass them through without throwing. It would be better for these classes to simply not call the Deserializers in this case; this would reduce the burden of implementers of {{Deserializer}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)