You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jostbg <gi...@git.apache.org> on 2018/01/23 09:09:55 UTC
[GitHub] activemq-artemis pull request #1806: [ARTEMIS-1629] Set connection.clientID ...
GitHub user jostbg opened a pull request:
https://github.com/apache/activemq-artemis/pull/1806
[ARTEMIS-1629] Set connection.clientID before executing ...
connection#validateUser
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jostbg/activemq-artemis ARTEMIS-1629
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1806.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1806
----
commit 7b92bbef1c708671a87cc97ec6501f8b72d6601c
Author: Johan Stenberg <35...@...>
Date: 2018-01-23T09:09:02Z
[ARTEMIS-1629] Set connection.clientID before executing connection#validateUser
----
---
[GitHub] activemq-artemis issue #1806: [ARTEMIS-1629] Set connection.clientID before ...
Posted by jostbg <gi...@git.apache.org>.
Github user jostbg commented on the issue:
https://github.com/apache/activemq-artemis/pull/1806
@jbertram Ok, done.
---
[GitHub] activemq-artemis issue #1806: [ARTEMIS-1629] Set connection.clientID before ...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1806
@jostbg, that's what I was looking for. Although I would expect the commits to be squashed together.
---
[GitHub] activemq-artemis issue #1806: [ARTEMIS-1629] Set connection.clientID before ...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1806
@jostbg thanks for the test :) +1.
---
[GitHub] activemq-artemis issue #1806: [ARTEMIS-1629] Set connection.clientID before ...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1806
Can there be a test case to a) show why this needs to be changed, b) avoid any future regression.
---
[GitHub] activemq-artemis pull request #1806: [ARTEMIS-1629] Set connection.clientID ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1806
---
[GitHub] activemq-artemis issue #1806: [ARTEMIS-1629] Set connection.clientID before ...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1806
@jostbg, you can extend StompTestBase and override the createServer() method. Look at the implementation of createServer() in StompTestBase to get an idea how to create/configure the server. The method `org.apache.activemq.artemis.core.server.ActiveMQServers#newActiveMQServer(org.apache.activemq.artemis.core.config.Configuration, javax.management.MBeanServer, org.apache.activemq.artemis.spi.core.security.ActiveMQSecurityManager, boolean)` will likely come in handy for you when creating your server.
---
[GitHub] activemq-artemis issue #1806: [ARTEMIS-1629] Set connection.clientID before ...
Posted by jostbg <gi...@git.apache.org>.
Github user jostbg commented on the issue:
https://github.com/apache/activemq-artemis/pull/1806
@michaelandrepearce @jbertram I added a test case to the JIRA that outlines the issue but I have no idea how to get it into the same form that is used in the stomp test cases in the integration-tests project. There seems to obvious way how to use a different SecurityManager when extending StompTestBase class.
---
[GitHub] activemq-artemis issue #1806: [ARTEMIS-1629] Set connection.clientID before ...
Posted by jostbg <gi...@git.apache.org>.
Github user jostbg commented on the issue:
https://github.com/apache/activemq-artemis/pull/1806
@michaelandrepearce @jbertram Is that kind of test what you are having in mind?
---