[jira] [Commented] (SLING-7343) Replace the custom RegexpPathMapping with the one contributed in Jackrabbit Vault

["Timothee Maret (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-7343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308020#comment-16308020 ] 

Timothee Maret commented on SLING-7343:
---------------------------------------

Thanks [~simone.tripodi]! 

The patch LGTM.

> Replace the custom RegexpPathMapping with the one contributed in Jackrabbit Vault
> ---------------------------------------------------------------------------------
>
>                 Key: SLING-7343
>                 URL: https://issues.apache.org/jira/browse/SLING-7343
>             Project: Sling
>          Issue Type: Improvement
>          Components: Content Distribution
>            Reporter: Simone Tripodi
>            Assignee: Simone Tripodi
>         Attachments: RegexpPathMapping.patch
>
>
> The {{org.apache.jackrabbit.vault-3.1.42}} contains the {{RegexpPathMapping}} implementation we contributed back to _Jackrabbit Vault_ time ago, so the idea is to getting rid of {{org.apache.sling.distribution.serialization.impl.vlt.RegexpPathMapping}} and replacing it directly with the {{org.apache.jackrabbit.vault.fs.api.RegexpPathMapping}}.
> The package containing such class is OSGi exported by the
> {noformat}
> org.apache.jackrabbit.vault.fs.api;version="2.6.0";uses:="javax.annotation,javax.jcr,org.xml.sax"
> {noformat}
> directive. That would make our lives easier and avoid to maintain external code by ourselves.
> [~teofili] [~marett] could you please have a look at the attached patch, before I check the modification in, please? TIA!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)