[GitHub] trafficserver issue #1184: TS-5030: Add API to get the unique client request...

[calavera <gi...@git.apache.org>]

Github user calavera commented on the issue:

    https://github.com/apache/trafficserver/pull/1184
  
    1) > There are APIs to get the two components that you are asking for, all you are doing is doing the string concatenation? That doesn't seem worth an entirely new API to me.
    
    The problem is that ATS defines how to concatenate those values inside the log format. If you want to keep logs and plugins consistent, you need to look at the code to see how the log generates the client request id. 
    
    From an administrator point of view, I don't care how that value in my log is generated, I do care about having the same consistent value across logs, server and plugins.
    
    From a developer point of view, the only way to keep that consistency is to replicate what ATS' log is doing. The only way to do that is by looking at the code. This breaks the purpose of having a well defined api.
    
    2) Assuming we want this, you definitely should not use the TS APIs in the InkAPI.cc implementation of the new API. You should use the same underlying APIs that are provided by the core implementation of the UUID and HttpSM respectively.
    
    I can make the changes accordingly.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---