You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/01 08:21:50 UTC

[GitHub] [shardingsphere] strongduanmu opened a new pull request, #21883: Add select from view test case for sql federation

strongduanmu opened a new pull request, #21883:
URL: https://github.com/apache/shardingsphere/pull/21883

   Ref #19580.
   
   Changes proposed in this pull request:
     - add select from view test case for sql federation
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] tuichenchuxin merged pull request #21883: Add select from view test case for sql federation

Posted by GitBox <gi...@apache.org>.
tuichenchuxin merged PR #21883:
URL: https://github.com/apache/shardingsphere/pull/21883


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] codecov-commenter commented on pull request #21883: Add select from view test case for sql federation

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #21883:
URL: https://github.com/apache/shardingsphere/pull/21883#issuecomment-1298349110

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21883?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#21883](https://codecov.io/gh/apache/shardingsphere/pull/21883?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fb237da) into [master](https://codecov.io/gh/apache/shardingsphere/commit/5e715611f140db6fe298d7c2d4ba450c60ab3fa6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5e71561) will **increase** coverage by `0.03%`.
   > The diff coverage is `34.44%`.
   
   > :exclamation: Current head fb237da differs from pull request most recent head 9ca4260. Consider uploading reports for the commit 9ca4260 to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #21883      +/-   ##
   ============================================
   + Coverage     61.03%   61.07%   +0.03%     
   - Complexity     2454     2455       +1     
   ============================================
     Files          4110     4108       -2     
     Lines         57260    57221      -39     
     Branches       9673     9666       -7     
   ============================================
   - Hits          34950    34947       -3     
   + Misses        19388    19352      -36     
     Partials       2922     2922              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../statement/rql/show/ShowStorageUnitsStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/21883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGlzdHNxbC9zdGF0ZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2Rpc3RzcWwvcGFyc2VyL3N0YXRlbWVudC9ycWwvc2hvdy9TaG93U3RvcmFnZVVuaXRzU3RhdGVtZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...exception/resource/DuplicateResourceException.java](https://codecov.io/gh/apache/shardingsphere/pull/21883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kaXN0c3FsL2V4Y2VwdGlvbi9yZXNvdXJjZS9EdXBsaWNhdGVSZXNvdXJjZUV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...on/resource/MissingRequiredResourcesException.java](https://codecov.io/gh/apache/shardingsphere/pull/21883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kaXN0c3FsL2V4Y2VwdGlvbi9yZXNvdXJjZS9NaXNzaW5nUmVxdWlyZWRSZXNvdXJjZXNFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...i/impl/AbstractInventoryIncrementalJobAPIImpl.java](https://codecov.io/gh/apache/shardingsphere/pull/21883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL2FwaS9pbXBsL0Fic3RyYWN0SW52ZW50b3J5SW5jcmVtZW50YWxKb2JBUElJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ine/core/task/InventoryIncrementalTasksRunner.java](https://codecov.io/gh/apache/shardingsphere/pull/21883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL3Rhc2svSW52ZW50b3J5SW5jcmVtZW50YWxUYXNrc1J1bm5lci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...peline/scenario/migration/MigrationJobAPIImpl.java](https://codecov.io/gh/apache/shardingsphere/pull/21883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9zY2VuYXJpby9taWdyYXRpb24vTWlncmF0aW9uSm9iQVBJSW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...deration/executor/FilterableTableScanExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/21883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL3NxbC1mZWRlcmF0aW9uL2V4ZWN1dG9yL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbGZlZGVyYXRpb24vZXhlY3V0b3IvRmlsdGVyYWJsZVRhYmxlU2NhbkV4ZWN1dG9yLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...ration/executor/TranslatableTableScanExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/21883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL3NxbC1mZWRlcmF0aW9uL2V4ZWN1dG9yL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbGZlZGVyYXRpb24vZXhlY3V0b3IvVHJhbnNsYXRhYmxlVGFibGVTY2FuRXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ration/original/OriginalSQLFederationExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/21883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL3NxbC1mZWRlcmF0aW9uL2V4ZWN1dG9yL29yaWdpbmFsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWxmZWRlcmF0aW9uL29yaWdpbmFsL09yaWdpbmFsU1FMRmVkZXJhdGlvbkV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...er/metadata/translatable/TranslatableDatabase.java](https://codecov.io/gh/apache/shardingsphere/pull/21883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL3NxbC1mZWRlcmF0aW9uL29wdGltaXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsZmVkZXJhdGlvbi9vcHRpbWl6ZXIvbWV0YWRhdGEvdHJhbnNsYXRhYmxlL1RyYW5zbGF0YWJsZURhdGFiYXNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | ... and [21 more](https://codecov.io/gh/apache/shardingsphere/pull/21883/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org