You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/15 22:39:40 UTC

[GitHub] [arrow] wesm commented on a change in pull request #8660: ARROW-10173: [Rust][DataFusion] Implement support for direct comparison to scalar values

wesm commented on a change in pull request #8660:
URL: https://github.com/apache/arrow/pull/8660#discussion_r523824755



##########
File path: rust/datafusion/src/physical_plan/mod.rs
##########
@@ -100,6 +100,30 @@ pub enum Distribution {
     SinglePartition,
 }
 
+/// Represents the result from an expression
+pub enum ColumnarValue {

Review comment:
       Note that our use of `Datum` in C++ is **far from perfect**, it's actually a relatively complex data structure and I've contemplated using something simplified that doesn't have as many non-trivial C++ objects inside it in the internals of function execution




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org