You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/26 15:19:36 UTC

[GitHub] [beam] eantyshev commented on a diff in pull request #23349: [Tour Of Beam] API adjustments

eantyshev commented on code in PR #23349:
URL: https://github.com/apache/beam/pull/23349#discussion_r980183380


##########
learning/tour-of-beam/backend/docker-compose.yml:
##########
@@ -25,4 +25,4 @@ services:
       - DATASTORE_LISTEN_ADDRESS=0.0.0.0:8081
     ports:
       - "8081:8081"
-    command: --consistency=1.0
+    command: --consistency=1.0 --store-on-disk

Review Comment:
   > --store-on-disk is a enabled by default not sure we need it here
   I believe better to set it explicitly, provided we have to define other cmd options, as the default may change in future
   
   > maybe we should try to set consistency to recommended 0.05 for development?
   This setup is about CI/CD, we don't want to introduce undefined behavior here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org