[jira] [Commented] (HBASE-5672) TestLruBlockCache#testBackgroundEvictionThread fails occasionally

["Enis Soztutar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-5672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13671084#comment-13671084 ] 

Enis Soztutar commented on HBASE-5672:
--------------------------------------

I was looking into backporting this in 0.94, but it seems that the patch (possibly mistakenly) went into 0.94 as a part of:
{code}
commit 2ac62a9eb6dce1df54a2ae5fe47035d186f80e69
Author: Matteo Bertozzi <mb...@apache.org>
Date:   Mon Mar 4 11:24:50 2013 +0000

    HBASE-7360 Backport Snapshots to 0.94
{code}
I'm marking fixed version against 0.94.6. 
                
> TestLruBlockCache#testBackgroundEvictionThread fails occasionally
> -----------------------------------------------------------------
>
>                 Key: HBASE-5672
>                 URL: https://issues.apache.org/jira/browse/HBASE-5672
>             Project: HBase
>          Issue Type: Bug
>            Reporter: chunhui shen
>            Assignee: chunhui shen
>             Fix For: 0.95.0
>
>         Attachments: HBASE-5672.patch, HBASE-5672v2.patch, HBASE-5672v3.patch
>
>
> We find TestLruBlockCache#testBackgroundEvictionThread fails occasionally.
> I think it's a problem of the test case.
> Because runEviction() only do evictionThread.evict():
> {code}
> public void evict() {
>       synchronized(this) {
>         this.notify(); // FindBugs NN_NAKED_NOTIFY
>       }
>     }
> {code}
> However when we call evictionThread.evict(), the evictionThread may haven't been in run() in the TestLruBlockCache#testBackgroundEvictionThread.
> If we run the test many times, we could find failture easily.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira