You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2019/09/12 21:02:42 UTC

[commons-configuration] branch master updated: Use current version of Checkstyle: 6.18 to 8.24.

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-configuration.git


The following commit(s) were added to refs/heads/master by this push:
     new d59b561  Use current version of Checkstyle: 6.18 to 8.24.
d59b561 is described below

commit d59b5612524a953c48c66fd7bbf6085f5dc3ac14
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Sep 12 17:02:39 2019 -0400

    Use current version of Checkstyle: 6.18 to 8.24.
---
 conf/checkstyle.xml     | 6 +++---
 pom.xml                 | 8 ++++++++
 src/changes/changes.xml | 3 +++
 3 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/conf/checkstyle.xml b/conf/checkstyle.xml
index 3fc1807..825a36e 100644
--- a/conf/checkstyle.xml
+++ b/conf/checkstyle.xml
@@ -59,6 +59,9 @@
         <property name="message" value="Line has trailing spaces."/>
     </module>
     <module name="FileLength"/>
+    <module name="LineLength">
+        <property name="max" value="120"/>
+    </module>
 
     <module name="TreeWalker">
 
@@ -101,9 +104,6 @@
 
         <!-- Checks for Size Violations.                    -->
         <!-- See http://checkstyle.sf.net/config_sizes.html -->
-        <module name="LineLength">
-            <property name="max" value="120"/>
-        </module>
         <module name="MethodLength"/>
         <module name="ParameterNumber"/>
 
diff --git a/pom.xml b/pom.xml
index f040bd3..49aa414 100644
--- a/pom.xml
+++ b/pom.xml
@@ -573,6 +573,7 @@
     <commons.jacoco.version>0.8.4</commons.jacoco.version>
     <commons.spotbugs.version>3.1.12.2</commons.spotbugs.version>
     <commons.javadoc.version>3.1.1</commons.javadoc.version>
+    <checkstyle.version>8.24</checkstyle.version>
 
     <!-- Commons Release Plugin -->
     <commons.bc.version>2.5</commons.bc.version>
@@ -633,6 +634,13 @@
             </sourceDirectories>
             <excludes>**/org/apache/commons/configuration2/plist/*.java</excludes>
           </configuration>
+          <dependencies>
+            <dependency>
+              <groupId>com.puppycrawl.tools</groupId>
+              <artifactId>checkstyle</artifactId>
+              <version>${checkstyle.version}</version>
+            </dependency>
+          </dependencies>
         </plugin>
       </plugins>
     </pluginManagement>
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index b6d6a24..1807cf3 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -78,6 +78,9 @@
       <action dev="ggregory" type="update" due-to="Gary Gregory">
         Update maven-checkstyle-plugin from 3.0.0 to 3.1.0. 
       </action>
+      <action dev="ggregory" type="update" due-to="Gary Gregory">
+        Use current version of Checkstyle: 6.18 to 8.24.
+      </action>
     </release>
     <release version="2.5" date="2019-05-23"
              description="Minor release with new features and updated dependencies.">