You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Mark Thomas <ma...@apache.org> on 2011/07/10 12:56:38 UTC

Preparing for a 7.0.19 tag

Just a quick summary of the regressions reported against 7.0.18 and
other issues that need to be fixed before 7.0.19 is tagged.

7.0.17 / 7.0.18 regressions
- IPv6 broken
  - fixed
  - no test case (nice to have but not essential for 7.0.19)

- AJP 400 errors
  - fixed
  - no test case (nice to have but not essential for 7.0.19)

- AJP keep-alive broken
  - not fixed
  - no test case (nice to have but not essential for 7.0.19)

- Open bugs
  - 51490
  - 51494

- Unit tests
  - Comet failures
    - Need more info from Rainer to determine if this is a regression

- TCK
  - Servlet TCK failure
    - I saw a failure with mod_proxy_ajp & NIO yesterday
      need to investigate
      Didn't appear to be related to AJP issues above

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: Preparing for a 7.0.19 tag

Posted by Mark Thomas <ma...@apache.org>.
On 10/07/2011 12:58, Rainer Jung wrote:
> On 10.07.2011 12:56, Mark Thomas wrote:
>> Just a quick summary of the regressions reported against 7.0.18 and
>> other issues that need to be fixed before 7.0.19 is tagged.
>>
>> 7.0.17 / 7.0.18 regressions
>> - IPv6 broken
>>   - fixed
>>   - no test case (nice to have but not essential for 7.0.19)
>>
>> - AJP 400 errors
>>   - fixed
>>   - no test case (nice to have but not essential for 7.0.19)
>>
>> - AJP keep-alive broken
>>   - not fixed
> 
> Hmmm, I can't reproduce this on trunk. Just for 7.0.18.

This may be the same problem as the 400 error. The connection was
certainly being closed after the error so that would explain it.

> 
>>   - no test case (nice to have but not essential for 7.0.19)
>>
>> - Open bugs
>>   - 51490
>>   - 51494
>>
>> - Unit tests
>>   - Comet failures
>>     - Need more info from Rainer to determine if this is a regression
> 
> *Not* a regression.

OK. The end result is OK, just not what the test expects. There probably
is a subtle bug here but one that has been around for a while.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: Preparing for a 7.0.19 tag

Posted by Rainer Jung <ra...@kippdata.de>.
On 10.07.2011 13:58, Rainer Jung wrote:
> - TestAsyncContextImpl fails for BIO, NIO and APR:
> 
> Testcase: testTimeoutListenerCompleteDispatch took 6.074 sec
> 	FAILED
> expected:<1> but was:<0>
> junit.framework.AssertionFailedError: expected:<1> but was:<0>
> 	at
> org.apache.catalina.core.TestAsyncContextImpl.validateAccessLog(TestAsyncContextImpl.java:1077)
> 	at
> org.apache.catalina.core.TestAsyncContextImpl.doTestTimeout(TestAsyncContextImpl.java:455)
> 	at
> org.apache.catalina.core.TestAsyncContextImpl.testTimeoutListenerCompleteDispatch(TestAsyncContextImpl.java:380)

Sorry, this is due to my adding an optional AccessLogValve to the test
suite today. It is off by default, and the failure only happens if I
switch it on. I'll investigate, but it is not a show-stopper, because by
default everything is fine.

Regards,

Rainer


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: Preparing for a 7.0.19 tag

Posted by Rainer Jung <ra...@kippdata.de>.
On 10.07.2011 12:56, Mark Thomas wrote:
> Just a quick summary of the regressions reported against 7.0.18 and
> other issues that need to be fixed before 7.0.19 is tagged.
> 
> 7.0.17 / 7.0.18 regressions
> - IPv6 broken
>   - fixed
>   - no test case (nice to have but not essential for 7.0.19)
> 
> - AJP 400 errors
>   - fixed
>   - no test case (nice to have but not essential for 7.0.19)
> 
> - AJP keep-alive broken
>   - not fixed

Hmmm, I can't reproduce this on trunk. Just for 7.0.18.

>   - no test case (nice to have but not essential for 7.0.19)
> 
> - Open bugs
>   - 51490
>   - 51494
> 
> - Unit tests
>   - Comet failures
>     - Need more info from Rainer to determine if this is a regression

*Not* a regression.

> - TCK
>   - Servlet TCK failure
>     - I saw a failure with mod_proxy_ajp & NIO yesterday
>       need to investigate
>       Didn't appear to be related to AJP issues above


- Wrong year formatting when using CLF (default) timestamp
  format in AccessLogValve (2 instead of 4 digits).


- No access log entry for TestCometProcessor.
  Tested using trunk with NIO and APR.
  Is it expected to produce one?


- TestAsyncContextImpl fails for BIO, NIO and APR:

Testcase: testTimeoutListenerCompleteDispatch took 6.074 sec
	FAILED
expected:<1> but was:<0>
junit.framework.AssertionFailedError: expected:<1> but was:<0>
	at
org.apache.catalina.core.TestAsyncContextImpl.validateAccessLog(TestAsyncContextImpl.java:1077)
	at
org.apache.catalina.core.TestAsyncContextImpl.doTestTimeout(TestAsyncContextImpl.java:455)
	at
org.apache.catalina.core.TestAsyncContextImpl.testTimeoutListenerCompleteDispatch(TestAsyncContextImpl.java:380)


Probably due to the following exception:


10-Jul-2011 13:56:35.846 SEVERE
org.apache.catalina.connector.CoyoteAdapter.asyncDispatch An exception
or error occurred in the container during the request processing
 java.lang.IllegalStateException: Calling [asyncDispatch()] is not valid
for a request with Async state [MUST_COMPLETE]
        at
org.apache.coyote.AsyncStateMachine.asyncDispatch(AsyncStateMachine.java:256)
        at
org.apache.coyote.http11.Http11Processor.actionInternal(Http11Processor.java:535)
        at
org.apache.coyote.http11.AbstractHttp11Processor.action(AbstractHttp11Processor.java:773)
        at org.apache.coyote.Request.action(Request.java:344)
        at
org.apache.catalina.core.AsyncContextImpl.dispatch(AsyncContextImpl.java:184)
        at
org.apache.catalina.core.AsyncContextImpl.dispatch(AsyncContextImpl.java:145)
        at
org.apache.catalina.core.TestAsyncContextImpl$TrackingListener.onTimeout(TestAsyncContextImpl.java:730)
        at
org.apache.catalina.core.AsyncListenerWrapper.fireOnTimeout(AsyncListenerWrapper.java:45)
        at
org.apache.catalina.core.AsyncContextImpl.timeout(AsyncContextImpl.java:117)
        at
org.apache.catalina.connector.CoyoteAdapter.asyncDispatch(CoyoteAdapter.java:289)
        at
org.apache.coyote.http11.AbstractHttp11Processor.asyncDispatch(AbstractHttp11Processor.java:1220)
        at
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:511)
        at
org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:302)
        at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
        at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
        at java.lang.Thread.run(Thread.java:662)


Stack for NIO:

10-Jul-2011 13:50:15.394 SEVERE
org.apache.catalina.connector.CoyoteAdapter.asyncDispatch An exception
or error occurred in the container during the request processing
 java.lang.IllegalStateException: Calling [asyncDispatch()] is not valid
for a request with Async state [MUST_COMPLETE]
        at
org.apache.coyote.AsyncStateMachine.asyncDispatch(AsyncStateMachine.java:256)
        at
org.apache.coyote.http11.Http11NioProcessor.actionInternal(Http11NioProcessor.java:611)
        at
org.apache.coyote.http11.AbstractHttp11Processor.action(AbstractHttp11Processor.java:773)
        at org.apache.coyote.Request.action(Request.java:344)
        at
org.apache.catalina.core.AsyncContextImpl.dispatch(AsyncContextImpl.java:184)
        at
org.apache.catalina.core.AsyncContextImpl.dispatch(AsyncContextImpl.java:145)
        at
org.apache.catalina.core.TestAsyncContextImpl$TrackingListener.onTimeout(TestAsyncContextImpl.java:730)
        at
org.apache.catalina.core.AsyncListenerWrapper.fireOnTimeout(AsyncListenerWrapper.java:45)
        at
org.apache.catalina.core.AsyncContextImpl.timeout(AsyncContextImpl.java:117)
        at
org.apache.catalina.connector.CoyoteAdapter.asyncDispatch(CoyoteAdapter.java:289)
        at
org.apache.coyote.http11.AbstractHttp11Processor.asyncDispatch(AbstractHttp11Processor.java:1220)
        at
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:511)
        at
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1540)
        at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
        at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
        at java.lang.Thread.run(Thread.java:662)


Stack for APR:

10-Jul-2011 13:48:28.336 SEVERE
org.apache.catalina.connector.CoyoteAdapter.asyncDispatch An exception
or error occurred in the container during the request processing
 java.lang.IllegalStateException: Calling [asyncDispatch()] is not valid
for a request with Async state [MUST_COMPLETE]
        at
org.apache.coyote.AsyncStateMachine.asyncDispatch(AsyncStateMachine.java:256)
        at
org.apache.coyote.http11.Http11AprProcessor.actionInternal(Http11AprProcessor.java:563)
        at
org.apache.coyote.http11.AbstractHttp11Processor.action(AbstractHttp11Processor.java:773)
        at org.apache.coyote.Request.action(Request.java:344)
        at
org.apache.catalina.core.AsyncContextImpl.dispatch(AsyncContextImpl.java:184)
        at
org.apache.catalina.core.AsyncContextImpl.dispatch(AsyncContextImpl.java:145)
        at
org.apache.catalina.core.TestAsyncContextImpl$TrackingListener.onTimeout(TestAsyncContextImpl.java:730)
        at
org.apache.catalina.core.AsyncListenerWrapper.fireOnTimeout(AsyncListenerWrapper.java:45)
        at
org.apache.catalina.core.AsyncContextImpl.timeout(AsyncContextImpl.java:117)
        at
org.apache.catalina.connector.CoyoteAdapter.asyncDispatch(CoyoteAdapter.java:289)
        at
org.apache.coyote.http11.AbstractHttp11Processor.asyncDispatch(AbstractHttp11Processor.java:1220)
        at
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:511)
        at
org.apache.tomcat.util.net.AprEndpoint$SocketProcessor.run(AprEndpoint.java:1737)
        at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
        at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
        at java.lang.Thread.run(Thread.java:662)


Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org