You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2009/09/13 00:51:14 UTC

svn commit: r814248 - in /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp: TestBasicDataSource.java TesterDriver.java

Author: sebb
Date: Sat Sep 12 22:51:13 2009
New Revision: 814248

URL: http://svn.apache.org/viewvc?rev=814248&view=rev
Log:
Make private immutable field final

Modified:
    commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestBasicDataSource.java
    commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TesterDriver.java

Modified: commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestBasicDataSource.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestBasicDataSource.java?rev=814248&r1=814247&r2=814248&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestBasicDataSource.java (original)
+++ commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestBasicDataSource.java Sat Sep 12 22:51:13 2009
@@ -45,7 +45,7 @@
     }
 
     protected BasicDataSource ds = null;
-    private static String CATALOG = "test catalog";
+    private static final String CATALOG = "test catalog";
 
     public void setUp() throws Exception {
         super.setUp();

Modified: commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TesterDriver.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TesterDriver.java?rev=814248&r1=814247&r2=814248&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TesterDriver.java (original)
+++ commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TesterDriver.java Sat Sep 12 22:51:13 2009
@@ -42,7 +42,7 @@
  * @version $Revision$ $Date$
  */
 public class TesterDriver implements Driver {
-    private static Properties validUserPasswords = new Properties();
+    private static final Properties validUserPasswords = new Properties();
     static {
         try {
             DriverManager.registerDriver(new TesterDriver());