You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by guoxiaolongzte <gi...@git.apache.org> on 2017/09/27 07:00:21 UTC

[GitHub] spark pull request #19360: [SPARK-22139][CORE]Remove the variable which is n...

GitHub user guoxiaolongzte opened a pull request:

    https://github.com/apache/spark/pull/19360

    [SPARK-22139][CORE]Remove the variable which is never used in SparkConf.scala

    ## What changes were proposed in this pull request?
    
    Remove the variable which is never used in SparkConf.scala.
    val executorClasspathKey = "spark.executor.extraClassPath"
    val driverOptsKey = "spark.driver.extraJavaOptions"
    val driverClassPathKey = "spark.driver.extraClassPath"
    val sparkExecutorInstances = "spark.executor.instances"
    They variables are never used. Because the implementation code for the validation rule has been removed in SPARK-17979.
    
    ## How was this patch tested?
    
    manual tests
    
    Please review http://spark.apache.org/contributing.html before opening a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/guoxiaolongzte/spark SPARK-22139

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19360.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19360
    
----
commit f345aa8487a64a0256c6965bc198ba8842cd0a51
Author: guoxiaolong <gu...@zte.com.cn>
Date:   2017-09-27T06:58:37Z

    [SPARK-22139] Remove the variable which is never used in SparkConf.scala

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19360: [SPARK-22139][CORE]Remove the variable which is never us...

Posted by guoxiaolongzte <gi...@git.apache.org>.
Github user guoxiaolongzte commented on the issue:

    https://github.com/apache/spark/pull/19360
  
    I was trying to find out more not used


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19360: [SPARK-22139][CORE]Remove the variable which is never us...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/19360
  
    Shall we close this one for now then?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19360: [SPARK-22139][CORE]Remove the variable which is never us...

Posted by guoxiaolongzte <gi...@git.apache.org>.
Github user guoxiaolongzte commented on the issue:

    https://github.com/apache/spark/pull/19360
  
    How do you find other similar mistakes?
    Of course, found a immediately resolved, or behind the code more and more chaos


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19360: [SPARK-22139][CORE]Remove the variable which is never us...

Posted by guoxiaolongzte <gi...@git.apache.org>.
Github user guoxiaolongzte commented on the issue:

    https://github.com/apache/spark/pull/19360
  
    @HyukjinKwon The problem of the PR you follow, I do not care, I will close this PR. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19360: [SPARK-22139][CORE]Remove the variable which is never us...

Posted by guoxiaolongzte <gi...@git.apache.org>.
Github user guoxiaolongzte commented on the issue:

    https://github.com/apache/spark/pull/19360
  
    @srowen 
    Because i was just studying the source code here.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19360: [SPARK-22139][CORE]Remove the variable which is never us...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/19360
  
    We could find like you did now. Otherwise, we could suggest to fix these instances in another PR from other guys fixing them. I personally don't support to open each PR for these if it is not the very first contribution, or the author is quite newbie to this project.
    
    I think you have contributed many fixes and it should be good to focus on fixing more actual issues, leaving those for them (or do this in a batch).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19360: [SPARK-22139][CORE]Remove the variable which is never us...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/19360
  
    Let's leave this closed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #19360: [SPARK-22139][CORE]Remove the variable which is n...

Posted by guoxiaolongzte <gi...@git.apache.org>.
Github user guoxiaolongzte closed the pull request at:

    https://github.com/apache/spark/pull/19360


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19360: [SPARK-22139][CORE]Remove the variable which is never us...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19360
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19360: [SPARK-22139][CORE]Remove the variable which is never us...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/19360
  
    They aren't used, but I do not think you should focus on opening JIRAs and PRs for each of these individually.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #19360: [SPARK-22139][CORE]Remove the variable which is n...

Posted by guoxiaolongzte <gi...@git.apache.org>.
Github user guoxiaolongzte closed the pull request at:

    https://github.com/apache/spark/pull/19360


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #19360: [SPARK-22139][CORE]Remove the variable which is n...

Posted by guoxiaolongzte <gi...@git.apache.org>.
GitHub user guoxiaolongzte reopened a pull request:

    https://github.com/apache/spark/pull/19360

    [SPARK-22139][CORE]Remove the variable which is never used in SparkConf.scala

    ## What changes were proposed in this pull request?
    
    Remove the variable which is never used in SparkConf.scala.
    val executorClasspathKey = "spark.executor.extraClassPath"
    val driverOptsKey = "spark.driver.extraJavaOptions"
    val driverClassPathKey = "spark.driver.extraClassPath"
    val sparkExecutorInstances = "spark.executor.instances"
    They variables are never used. Because the implementation code for the validation rule has been removed in SPARK-17979.
    
    ## How was this patch tested?
    
    manual tests
    
    Please review http://spark.apache.org/contributing.html before opening a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/guoxiaolongzte/spark SPARK-22139

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19360.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19360
    
----
commit f345aa8487a64a0256c6965bc198ba8842cd0a51
Author: guoxiaolong <gu...@zte.com.cn>
Date:   2017-09-27T06:58:37Z

    [SPARK-22139] Remove the variable which is never used in SparkConf.scala

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19360: [SPARK-22139][CORE]Remove the variable which is never us...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19360
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19360: [SPARK-22139][CORE]Remove the variable which is never us...

Posted by guoxiaolongzte <gi...@git.apache.org>.
Github user guoxiaolongzte commented on the issue:

    https://github.com/apache/spark/pull/19360
  
    Okay, I accept your opinion


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19360: [SPARK-22139][CORE]Remove the variable which is never us...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/19360
  
    Let's buffer such things and flush it in a batch rather than arbitrarily and individually.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org