You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "pgaref (via GitHub)" <gi...@apache.org> on 2023/05/25 05:54:25 UTC
[GitHub] [flink] pgaref opened a new pull request, #22646: [FLINK-31896][runtime] Extend web interface to support failure labels
pgaref opened a new pull request, #22646:
URL: https://github.com/apache/flink/pull/22646
https://issues.apache.org/jira/browse/FLINK-31896
* ExceptionInfo now includes failureLabels
* Exception History tab on JobExceptions page now exposes failure labels
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-31896][runtime] Extend web interface to support failure labels [flink]
Posted by "dmvk (via GitHub)" <gi...@apache.org>.
dmvk merged PR #22646:
URL: https://github.com/apache/flink/pull/22646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangzzu commented on a diff in pull request #22646: [FLINK-31896][runtime] Extend web interface to support failure labels
Posted by "wangzzu (via GitHub)" <gi...@apache.org>.
wangzzu commented on code in PR #22646:
URL: https://github.com/apache/flink/pull/22646#discussion_r1329641016
##########
flink-runtime-web/web-dashboard/src/app/pages/job/exceptions/job-exceptions.component.html:
##########
@@ -53,6 +54,9 @@
<td>
<div class="name">{{ item.selected.exceptionName }}</div>
</td>
+ <td>
+ {{ item.selected.failureLabels ? (item.selected.failureLabels | json) : 'None' }}
Review Comment:
@dmvk Do you mean to add a tag component to json here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #22646: [FLINK-31896][runtime] Extend web interface to support failure labels
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22646:
URL: https://github.com/apache/flink/pull/22646#issuecomment-1562320298
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1cde25a1734471f27308493b1992ed6b645f581d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1cde25a1734471f27308493b1992ed6b645f581d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1cde25a1734471f27308493b1992ed6b645f581d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dmvk commented on pull request #22646: [FLINK-31896][runtime] Extend web interface to support failure labels
Posted by "dmvk (via GitHub)" <gi...@apache.org>.
dmvk commented on PR #22646:
URL: https://github.com/apache/flink/pull/22646#issuecomment-1570232063
do you have a screenshot of how the result looks like?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-31896][runtime] Extend web interface to support failure labels [flink]
Posted by "pgaref (via GitHub)" <gi...@apache.org>.
pgaref commented on PR #22646:
URL: https://github.com/apache/flink/pull/22646#issuecomment-1835461622
Hey @dmvk this is now ready for review -- attached UI screenshots!
Please let me know what you think!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dmvk commented on a diff in pull request #22646: [FLINK-31896][runtime] Extend web interface to support failure labels
Posted by "dmvk (via GitHub)" <gi...@apache.org>.
dmvk commented on code in PR #22646:
URL: https://github.com/apache/flink/pull/22646#discussion_r1211718191
##########
flink-runtime-web/web-dashboard/src/app/pages/job/exceptions/job-exceptions.component.html:
##########
@@ -53,6 +54,9 @@
<td>
<div class="name">{{ item.selected.exceptionName }}</div>
</td>
+ <td>
+ {{ item.selected.failureLabels ? (item.selected.failureLabels | json) : 'None' }}
Review Comment:
🤔 Have you looked into the tag component of NG-zorro (the underlying UI library we're using)? That could look quite nice.
https://ng.ant.design/components/tag/en
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-31896][runtime] Extend web interface to support failure labels [flink]
Posted by "dmvk (via GitHub)" <gi...@apache.org>.
dmvk commented on code in PR #22646:
URL: https://github.com/apache/flink/pull/22646#discussion_r1411713724
##########
flink-runtime-web/web-dashboard/src/app/pages/job/exceptions/job-exceptions.component.html:
##########
@@ -52,6 +52,12 @@
<td>{{ item.selected.timestamp | date: 'yyyy-MM-dd HH:mm:ss' }}</td>
<td>
<div class="name">{{ item.selected.exceptionName }}</div>
+ <nz-tag
+ *ngFor="let label of item.selected.failureLabels | keyvalue"
+ [nzColor]="'#ff0000'"
Review Comment:
Can we go with a pre-defined color here? Eg. `<nz-tag nzColor="error">error</nz-tag>`?
https://ng.ant.design/components/tag/en
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org