You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "sokojh (via GitHub)" <gi...@apache.org> on 2026/09/07 05:05:53 UTC
[PR] Add tests for the AWS Batch executor boto schemas [airflow]
sokojh opened a new pull request, #72609:
URL: https://github.com/apache/airflow/pull/72609
### Why
`providers/amazon/.../executors/batch/boto_schema.py` is on the `OVERLOOKED_TESTS`
allowlist in `airflow-core/tests/unit/always/test_project_structure.py`, tracked by
the meta issue #35442.
Unlike most entries on that list, the three schemas in this module are not covered
indirectly either — no file under any `providers/*/tests/` directory references
`BatchSubmitJobResponseSchema`, `BatchJobDetailSchema` or
`BatchDescribeJobsResponseSchema`. (For contrast, `build_submit_kwargs` in the
sibling `batch_executor_config.py` *is* exercised from `test_batch_executor.py`,
which is why this PR is scoped to `boto_schema.py` alone.)
These schemas parse live AWS Batch API responses, so the behaviour worth pinning
down is the part that is easy to break silently: the `data_key` mapping from the
API's camelCase to Airflow's snake_case, the `unknown = EXCLUDE` policy that lets
the schemas tolerate fields AWS adds over time, and the `@post_load` hook that
makes `BatchJobDetailSchema` return a `BatchJob` rather than a plain dict.
### How
Adds `providers/amazon/tests/unit/amazon/aws/executors/batch/test_boto_schema.py`
with one test class per schema, covering for each:
- the happy-path load and the `jobId` → `job_id` renaming,
- that unknown keys returned by `submit_job` / `describe_jobs` are dropped rather
than raising,
- that a missing required field raises `ValidationError`,
- that `BatchJobDetailSchema` returns a `BatchJob` instance with `status_reason`
left as `None` when the API omits it,
- that `BatchDescribeJobsResponseSchema` builds one `BatchJob` per entry, accepts
an empty `jobs` list, and propagates a nested job's `ValidationError`.
No production code is touched.
### What
13 tests added. The module's entry is removed from `OVERLOOKED_TESTS` in the same
PR, as that list fails when a listed test file exists.
Verified locally:
```
uv run --project providers/amazon pytest \
providers/amazon/tests/unit/amazon/aws/executors/batch/test_boto_schema.py -v
# 13 passed
uv run --project airflow-core pytest \
airflow-core/tests/unit/always/test_project_structure.py -q
# 10 passed, 1 xfailed
```
related: #35442
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code (Opus 5) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add tests for the AWS Batch executor boto schemas [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck merged PR #72609:
URL: https://github.com/apache/airflow/pull/72609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add tests for the AWS Batch executor boto schemas [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #72609:
URL: https://github.com/apache/airflow/pull/72609#issuecomment-5603739910
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add tests for the AWS Batch executor boto schemas [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #72609:
URL: https://github.com/apache/airflow/pull/72609#issuecomment-5565309147
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our [Contributors' Guide](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example Dag that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org