You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jason Huynh <hu...@gmail.com> on 2016/04/08 20:37:42 UTC
Review Request 45938: GEODE-1062: Undoing reduction in wait time
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45938/
-----------------------------------------------------------
Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
Repository: geode
Description
-------
Some tests with overflow require the full 240000 millisecond timeout...
Diffs
-----
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java 130f960
Diff: https://reviews.apache.org/r/45938/diff/
Testing
-------
Thanks,
Jason Huynh
Re: Review Request 45938: GEODE-1062: Undoing reduction in wait time
Posted by Barry Oglesby <bo...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45938/#review127870
-----------------------------------------------------------
Ship it!
Ship It!
- Barry Oglesby
On April 8, 2016, 6:37 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45938/
> -----------------------------------------------------------
>
> (Updated April 8, 2016, 6:37 p.m.)
>
>
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Some tests with overflow require the full 240000 millisecond timeout...
>
>
> Diffs
> -----
>
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java 130f960
>
> Diff: https://reviews.apache.org/r/45938/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>
Re: Review Request 45938: GEODE-1062: Undoing reduction in wait time
Posted by Nabarun Nag <nn...@pivotal.io>.
As per Jason's advice I will open a new ticket for rewriting the test case
design as tests are not suppose to wait for 4 min.
Also, while running all the WAN tests on IntelliJ I was able to find more
tests with timing issue which Jason and me solved earlier. (Running two
IntelliJ instances simultaneously )
Will create the ticket and push in the changes.
On Fri, Apr 8, 2016 at 1:45 PM Barry Oglesby <bo...@pivotal.io> wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45938/
>
> Ship it!
>
> Ship It!
>
>
> - Barry Oglesby
>
> On April 8th, 2016, 8:26 p.m. UTC, Jason Huynh wrote:
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag,
> Dan Smith, and xiaojian zhou.
> By Jason Huynh.
>
> *Updated April 8, 2016, 8:26 p.m.*
> *Repository: * geode
> Description
>
> Some tests with overflow require the full 240000 millisecond timeout...
>
> Diffs
>
> - geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java
> (130f960)
>
> View Diff <https://reviews.apache.org/r/45938/diff/>
>
Re: Review Request 45938: GEODE-1062: Undoing reduction in wait time
Posted by Barry Oglesby <bo...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45938/#review127879
-----------------------------------------------------------
Ship it!
Ship It!
- Barry Oglesby
On April 8, 2016, 8:26 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45938/
> -----------------------------------------------------------
>
> (Updated April 8, 2016, 8:26 p.m.)
>
>
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Some tests with overflow require the full 240000 millisecond timeout...
>
>
> Diffs
> -----
>
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java 130f960
>
> Diff: https://reviews.apache.org/r/45938/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>
Re: Review Request 45938: GEODE-1062: Undoing reduction in wait time
Posted by Jason Huynh <hu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45938/
-----------------------------------------------------------
(Updated April 8, 2016, 8:26 p.m.)
Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
Changes
-------
Updated diff to add a new method signature. Any tests that are failing due to the defaulted 30 seconds can now be changed on a per test basis to wait for however long the test thinks it needs.
Repository: geode
Description
-------
Some tests with overflow require the full 240000 millisecond timeout...
Diffs (updated)
-----
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java 130f960
Diff: https://reviews.apache.org/r/45938/diff/
Testing
-------
Thanks,
Jason Huynh
Re: Review Request 45938: GEODE-1062: Undoing reduction in wait time
Posted by Jason Huynh <hu...@gmail.com>.
> On April 8, 2016, 8:02 p.m., Barry Oglesby wrote:
> > Maybe that timeout should be configurable? Most times 4 minutes might as well be forever.
Yes, that would be a good idea. I'm trying to revert this one change in the big refactoring I did earlier for GEODE-1062. I didn't think anything would need to wait 4 minutes but Naba found a test that fails for him on his machine. Most of the properly passing tests will actually complete before the 4 minutes due to this being a wait criterion.
- Jason
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45938/#review127865
-----------------------------------------------------------
On April 8, 2016, 6:37 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45938/
> -----------------------------------------------------------
>
> (Updated April 8, 2016, 6:37 p.m.)
>
>
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Some tests with overflow require the full 240000 millisecond timeout...
>
>
> Diffs
> -----
>
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java 130f960
>
> Diff: https://reviews.apache.org/r/45938/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>
Re: Review Request 45938: GEODE-1062: Undoing reduction in wait time
Posted by Jason Huynh <hu...@gmail.com>.
> On April 8, 2016, 8:02 p.m., Barry Oglesby wrote:
> > Maybe that timeout should be configurable? Most times 4 minutes might as well be forever.
>
> Jason Huynh wrote:
> Yes, that would be a good idea. I'm trying to revert this one change in the big refactoring I did earlier for GEODE-1062. I didn't think anything would need to wait 4 minutes but Naba found a test that fails for him on his machine. Most of the properly passing tests will actually complete before the 4 minutes due to this being a wait criterion.
>
> Barry Oglesby wrote:
> Right, but if it isn't a "properly passing test," then you're stuck waiting for 4 minutes for it to fail. I'm sure all our tests will pass from now on, so we don't have to worry about this wait time.
Or maybe I can leave this change at 30 seconds and any test that fails from this can be rewritten to not rely on the full 4 minutes?
- Jason
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45938/#review127865
-----------------------------------------------------------
On April 8, 2016, 6:37 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45938/
> -----------------------------------------------------------
>
> (Updated April 8, 2016, 6:37 p.m.)
>
>
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Some tests with overflow require the full 240000 millisecond timeout...
>
>
> Diffs
> -----
>
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java 130f960
>
> Diff: https://reviews.apache.org/r/45938/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>
Re: Review Request 45938: GEODE-1062: Undoing reduction in wait time
Posted by Barry Oglesby <bo...@pivotal.io>.
> On April 8, 2016, 8:02 p.m., Barry Oglesby wrote:
> > Maybe that timeout should be configurable? Most times 4 minutes might as well be forever.
>
> Jason Huynh wrote:
> Yes, that would be a good idea. I'm trying to revert this one change in the big refactoring I did earlier for GEODE-1062. I didn't think anything would need to wait 4 minutes but Naba found a test that fails for him on his machine. Most of the properly passing tests will actually complete before the 4 minutes due to this being a wait criterion.
Right, but if it isn't a "properly passing test," then you're stuck waiting for 4 minutes for it to fail. I'm sure all our tests will pass from now on, so we don't have to worry about this wait time.
- Barry
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45938/#review127865
-----------------------------------------------------------
On April 8, 2016, 6:37 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45938/
> -----------------------------------------------------------
>
> (Updated April 8, 2016, 6:37 p.m.)
>
>
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Some tests with overflow require the full 240000 millisecond timeout...
>
>
> Diffs
> -----
>
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java 130f960
>
> Diff: https://reviews.apache.org/r/45938/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>
Re: Review Request 45938: GEODE-1062: Undoing reduction in wait time
Posted by Barry Oglesby <bo...@pivotal.io>.
> On April 8, 2016, 8:02 p.m., Barry Oglesby wrote:
> > Maybe that timeout should be configurable? Most times 4 minutes might as well be forever.
>
> Jason Huynh wrote:
> Yes, that would be a good idea. I'm trying to revert this one change in the big refactoring I did earlier for GEODE-1062. I didn't think anything would need to wait 4 minutes but Naba found a test that fails for him on his machine. Most of the properly passing tests will actually complete before the 4 minutes due to this being a wait criterion.
>
> Barry Oglesby wrote:
> Right, but if it isn't a "properly passing test," then you're stuck waiting for 4 minutes for it to fail. I'm sure all our tests will pass from now on, so we don't have to worry about this wait time.
>
> Jason Huynh wrote:
> Or maybe I can leave this change at 30 seconds and any test that fails from this can be rewritten to not rely on the full 4 minutes?
Thats a good idea. I guess it depends on why the test needs 4 minutes to validateRegionSize. I wouldn't worry about it too much. Your change is just fine.
- Barry
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45938/#review127865
-----------------------------------------------------------
On April 8, 2016, 6:37 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45938/
> -----------------------------------------------------------
>
> (Updated April 8, 2016, 6:37 p.m.)
>
>
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Some tests with overflow require the full 240000 millisecond timeout...
>
>
> Diffs
> -----
>
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java 130f960
>
> Diff: https://reviews.apache.org/r/45938/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>
Re: Review Request 45938: GEODE-1062: Undoing reduction in wait time
Posted by Barry Oglesby <bo...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45938/#review127865
-----------------------------------------------------------
Maybe that timeout should be configurable? Most times 4 minutes might as well be forever.
- Barry Oglesby
On April 8, 2016, 6:37 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45938/
> -----------------------------------------------------------
>
> (Updated April 8, 2016, 6:37 p.m.)
>
>
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Some tests with overflow require the full 240000 millisecond timeout...
>
>
> Diffs
> -----
>
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java 130f960
>
> Diff: https://reviews.apache.org/r/45938/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>