You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/06/12 03:22:35 UTC

[GitHub] codecov-io commented on issue #3750: Fix arithmetic bug calculating blackbox and managed invokers.

codecov-io commented on issue #3750: Fix arithmetic bug calculating blackbox and managed invokers.
URL: https://github.com/apache/incubator-openwhisk/pull/3750#issuecomment-396453489
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750?src=pr&el=h1) Report
   > Merging [#3750](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/8f581036f1419590b659510a6474044901bcb0f5?src=pr&el=desc) will **increase** coverage by `1%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750/graphs/tree.svg?src=pr&token=l0YmsiSAso&width=650&height=150)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #3750   +/-   ##
   =======================================
   + Coverage   73.94%   74.94%   +1%     
   =======================================
     Files         128      128           
     Lines        6086     6086           
     Branches      388      388           
   =======================================
   + Hits         4500     4561   +61     
   + Misses       1586     1525   -61
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...e/loadBalancer/ShardingContainerPoolBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbG9hZEJhbGFuY2VyL1NoYXJkaW5nQ29udGFpbmVyUG9vbEJhbGFuY2VyLnNjYWxh) | `32.54% <100%> (ø)` | :arrow_up: |
   | [...cala/src/main/scala/whisk/http/ErrorResponse.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvRXJyb3JSZXNwb25zZS5zY2FsYQ==) | `89.77% <0%> (+1.13%)` | :arrow_up: |
   | [...on/scala/src/main/scala/whisk/common/Logging.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Mb2dnaW5nLnNjYWxh) | `87.35% <0%> (+1.14%)` | :arrow_up: |
   | [...ain/scala/whisk/core/entity/ActivationResult.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0FjdGl2YXRpb25SZXN1bHQuc2NhbGE=) | `92.3% <0%> (+1.53%)` | :arrow_up: |
   | [...in/scala/whisk/utils/ExecutionContextFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL3V0aWxzL0V4ZWN1dGlvbkNvbnRleHRGYWN0b3J5LnNjYWxh) | `100% <0%> (+7.69%)` | :arrow_up: |
   | [...rc/main/scala/whisk/core/entity/ExecManifest.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWNNYW5pZmVzdC5zY2FsYQ==) | `96.34% <0%> (+14.63%)` | :arrow_up: |
   | [...whisk/connector/kafka/KafkaConsumerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYUNvbnN1bWVyQ29ubmVjdG9yLnNjYWxh) | `58.33% <0%> (+31.24%)` | :arrow_up: |
   | [...whisk/connector/kafka/KafkaProducerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYVByb2R1Y2VyQ29ubmVjdG9yLnNjYWxh) | `58.33% <0%> (+36.11%)` | :arrow_up: |
   | [...whisk/connector/kafka/KafkaMessagingProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYU1lc3NhZ2luZ1Byb3ZpZGVyLnNjYWxh) | `88.46% <0%> (+65.38%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750?src=pr&el=footer). Last update [8f58103...8f58103](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services