You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/02/16 23:20:00 UTC

[jira] [Commented] (ORC-304) Fix TestRecordReaderImpl to not fail with new storage-api

    [ https://issues.apache.org/jira/browse/ORC-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368003#comment-16368003 ] 

ASF GitHub Bot commented on ORC-304:
------------------------------------

GitHub user omalley opened a pull request:

    https://github.com/apache/orc/pull/219

    ORC-304. Fix TestRecordReaderImpl to work with newer storage-api rele…

    …ases.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/omalley/orc orc-304

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/orc/pull/219.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #219
    
----
commit 817c894b6169478d0d027c56cb843f23000ba563
Author: Owen O'Malley <om...@...>
Date:   2018-02-16T23:17:45Z

    ORC-304. Fix TestRecordReaderImpl to work with newer storage-api releases.

----


> Fix TestRecordReaderImpl to not fail with new storage-api
> ---------------------------------------------------------
>
>                 Key: ORC-304
>                 URL: https://issues.apache.org/jira/browse/ORC-304
>             Project: ORC
>          Issue Type: Test
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>            Priority: Major
>
> Hive's storage-api has changed so that with diskRanges with doMerge = false will fail if the ranges overlap. We also call with doMerge = true in the reader, but the tests use doMerge = false. I propose that we change this so that the tests all use doMerge = true also.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)