[GitHub] [celix] pnoltes edited a comment on issue #196: Support multiple build configurations

[GitBox <gi...@apache.org>]

pnoltes edited a comment on issue #196:
URL: https://github.com/apache/celix/issues/196#issuecomment-616520404


   > When both configurations are the same, the Targets-* files are kept. So that makes sense.
   > 
   > Additional question, what types of builds do we want to install? I think the following makes sense:
   > 
   > * Only use a postfix for the libraries for Debug
   > * Always use build type as postfix for bundles, except when it is release (not sure about this one)
   > * Always use build type as postfix for CelixTargets file
   > 
   > For the second one (bundle files), it might also make sense to only use a postfix for Debug, or the other way around, always use a postfix. Since the Targets files already supplies a simplified name for usage in a build.
   > 
   
   I would prefer bundles with a postfix, with exception for the Release or RelWithDebInfo build type.
   For the celix targets cmake file, always generate a generic one (without postfix) and one with postfix. The generic will expect and include (based on its own location) a celix targets file with a build type postfix. 
   So maybe it could be as simple as: 
   ```Cmake
   include(CelixTargets-${CMAKE_BUILD_TYPE}.cmake)
   ```
   
   > Do we have an example on how the Targets files are being used?
   See cmake/CelixConfig.cmake line 33


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org