You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/04/30 05:53:02 UTC

[GitHub] [arrow] emkornfield commented on a change in pull request #7060: ARROW-8619: [C++] Use distinct enum values for MonthInterval, DayTimeInterval

emkornfield commented on a change in pull request #7060:
URL: https://github.com/apache/arrow/pull/7060#discussion_r417769294



##########
File path: r/R/enums.R
##########
@@ -42,12 +42,35 @@ DateUnit <- enum("DateUnit", DAY = 0L, MILLI = 1L)
 #' @rdname enums
 #' @export
 Type <- enum("Type::type",
-  "NA" = 0L, BOOL = 1L, UINT8 = 2L, INT8 = 3L, UINT16 = 4L, INT16 = 5L,
-  UINT32 = 6L, INT32 = 7L, UINT64 = 8L, INT64 = 9L,
-  HALF_FLOAT = 10L, FLOAT = 11L, DOUBLE = 12L, STRING = 13L,
-  BINARY = 14L, FIXED_SIZE_BINARY = 15L, DATE32 = 16L, DATE64 = 17L, TIMESTAMP = 18L,
-  TIME32 = 19L, TIME64 = 20L, INTERVAL = 21L, DECIMAL = 22L, LIST = 23L, STRUCT = 24L,
-  UNION = 25L, DICTIONARY = 26L, MAP = 27L
+  "NA" = 0L,
+  BOOL = 1L,
+  UINT8 = 2L,
+  INT8 = 3L,
+  UINT16 = 4L,
+  INT16 = 5L,
+  UINT32 = 6L,
+  INT32 = 7L,
+  UINT64 = 8L,
+  INT64 = 9L,
+  HALF_FLOAT = 10L,
+  FLOAT = 11L,
+  DOUBLE = 12L,
+  STRING = 13L,
+  BINARY = 14L,
+  FIXED_SIZE_BINARY = 15L,
+  DATE32 = 16L,
+  DATE64 = 17L,
+  TIMESTAMP = 18L,
+  TIME32 = 19L,
+  TIME64 = 20L,
+  INTERVAL_MONTHS = 21L,

Review comment:
       are these enums stored anyplace?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org