You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/03/02 00:55:00 UTC

[jira] [Commented] (NIFI-4855) The layout of NiFi API document is broken

    [ https://issues.apache.org/jira/browse/NIFI-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382939#comment-16382939 ] 

ASF GitHub Bot commented on NIFI-4855:
--------------------------------------

GitHub user tasanuma opened a pull request:

    https://github.com/apache/nifi/pull/2503

    NIFI-4855: The layout of NiFi API document is broken

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tasanuma/nifi NIFI-4855

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2503.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2503
    
----
commit 7f0d090ede5c45c75304c2939b3abe812ad04f1f
Author: Takanobu Asanuma <ta...@...>
Date:   2018-03-01T13:57:21Z

    Fix the layout of NiFi API document

----


> The layout of NiFi API document is broken
> -----------------------------------------
>
>                 Key: NIFI-4855
>                 URL: https://issues.apache.org/jira/browse/NIFI-4855
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Documentation &amp; Website
>    Affects Versions: 1.5.0
>            Reporter: Takanobu Asanuma
>            Assignee: Takanobu Asanuma
>            Priority: Major
>         Attachments: broken_ui.png, fixed_ui.001.png
>
>
> This is reported by Hiroaki Nawa.
> Looks like _Controller_ section incudes _Versions_ section mistakenly, and the layout is broken.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)