You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "vamossagar12 (via GitHub)" <gi...@apache.org> on 2023/04/25 05:42:45 UTC
[GitHub] [kafka] vamossagar12 opened a new pull request, #13634: KAFKA-14929: Fixing flaky test putTopicStateRetriableFailure
vamossagar12 opened a new pull request, #13634:
URL: https://github.com/apache/kafka/pull/13634
Fixing flaky test putTopicStateRetriableFailure by adding a timeout to have the background thread kicked in which invokes KafkaBasedLog#send.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] machi1990 commented on a diff in pull request #13634: KAFKA-14929: Fixing flaky test putTopicStateRetriableFailure
Posted by "machi1990 (via GitHub)" <gi...@apache.org>.
machi1990 commented on code in PR #13634:
URL: https://github.com/apache/kafka/pull/13634#discussion_r1176376840
##########
connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaStatusBackingStoreFormatTest.java:
##########
@@ -216,7 +216,7 @@ public void putTopicStateRetriableFailure() {
}).when(kafkaBasedLog).send(eq(key), valueCaptor.capture(), any(Callback.class));
store.put(topicStatus);
- verify(kafkaBasedLog, times(2)).send(any(), any(), any());
+ verify(kafkaBasedLog, timeout(1000).times(2)).send(any(), any(), any());
Review Comment:
Hi @vamossagar12 thanks for the PR.
Just for my own understanding, how was the timeout value chosen?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13634: KAFKA-14929: Fixing flaky test putTopicStateRetriableFailure
Posted by "vamossagar12 (via GitHub)" <gi...@apache.org>.
vamossagar12 commented on code in PR #13634:
URL: https://github.com/apache/kafka/pull/13634#discussion_r1177099657
##########
connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaStatusBackingStoreFormatTest.java:
##########
@@ -216,7 +216,7 @@ public void putTopicStateRetriableFailure() {
}).when(kafkaBasedLog).send(eq(key), valueCaptor.capture(), any(Callback.class));
store.put(topicStatus);
- verify(kafkaBasedLog, times(2)).send(any(), any(), any());
+ verify(kafkaBasedLog, timeout(1000).times(2)).send(any(), any(), any());
Review Comment:
@machi1990 it was originally 300 ms but @viktorsomogyi suggested to bump it up to 1s https://github.com/apache/kafka/pull/13594#discussion_r1175222973. @jolshan i haven't seen this test fail in the last few builds with this PR and https://github.com/apache/kafka/pull/13594.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] viktorsomogyi merged pull request #13634: KAFKA-14929: Fixing flaky test putTopicStateRetriableFailure
Posted by "viktorsomogyi (via GitHub)" <gi...@apache.org>.
viktorsomogyi merged PR #13634:
URL: https://github.com/apache/kafka/pull/13634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] machi1990 commented on a diff in pull request #13634: KAFKA-14929: Fixing flaky test putTopicStateRetriableFailure
Posted by "machi1990 (via GitHub)" <gi...@apache.org>.
machi1990 commented on code in PR #13634:
URL: https://github.com/apache/kafka/pull/13634#discussion_r1177474423
##########
connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaStatusBackingStoreFormatTest.java:
##########
@@ -216,7 +216,7 @@ public void putTopicStateRetriableFailure() {
}).when(kafkaBasedLog).send(eq(key), valueCaptor.capture(), any(Callback.class));
store.put(topicStatus);
- verify(kafkaBasedLog, times(2)).send(any(), any(), any());
+ verify(kafkaBasedLog, timeout(1000).times(2)).send(any(), any(), any());
Review Comment:
thanks @vamossagar12 for the reply. 1s seems like a high enough value timeout so it might be enough to make this test resilient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jolshan commented on a diff in pull request #13634: KAFKA-14929: Fixing flaky test putTopicStateRetriableFailure
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on code in PR #13634:
URL: https://github.com/apache/kafka/pull/13634#discussion_r1177067744
##########
connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaStatusBackingStoreFormatTest.java:
##########
@@ -216,7 +216,7 @@ public void putTopicStateRetriableFailure() {
}).when(kafkaBasedLog).send(eq(key), valueCaptor.capture(), any(Callback.class));
store.put(topicStatus);
- verify(kafkaBasedLog, times(2)).send(any(), any(), any());
+ verify(kafkaBasedLog, timeout(1000).times(2)).send(any(), any(), any());
Review Comment:
Are we concerned this could still be flaky?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org