You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/09/24 20:08:07 UTC

Review Request 38724: Remove wrong properties from 2.2 YARN config

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38724/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Sumit Mohanty.


Bugs: AMBARI-13232
    https://issues.apache.org/jira/browse/AMBARI-13232


Repository: ambari


Description
-------

Properties under question are 

yarn.scheduler.capacity.root.accessible-node-labels.default.capacity
yarn.scheduler.capacity.root.accessible-node-labels.default.maximum-capacity

These properties yesterday were removed from 2.3 stack


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/capacity-scheduler.xml f1d4b48 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/capacity-scheduler.xml fd9980c 
  ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_1.3_to_2.2.json d5087c3 
  ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.0_to_2.2.2.json cc4400a 
  ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.0_to_2.2.4.json 89c732a 
  ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.1_to_2.2.2.json 017fb73 
  ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.1_to_2.2.4.json 17f9030 

Diff: https://reviews.apache.org/r/38724/diff/


Testing
-------

I've removed properties from 2.2 stack, and also removed overrides from 2.3 stack. On both stacks, properties are absent after deployment and service checks pass
Also I've checked manual upgrade 2.1->2.2, and 2.2->2.3


Thanks,

Dmitro Lisnichenko


Re: Review Request 38724: Remove wrong properties from 2.2 YARN config

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38724/#review100440
-----------------------------------------------------------

Ship it!


Ship It!

- Jonathan Hurley


On Sept. 24, 2015, 2:08 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38724/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2015, 2:08 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-13232
>     https://issues.apache.org/jira/browse/AMBARI-13232
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Properties under question are 
> 
> yarn.scheduler.capacity.root.accessible-node-labels.default.capacity
> yarn.scheduler.capacity.root.accessible-node-labels.default.maximum-capacity
> 
> These properties yesterday were removed from 2.3 stack
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/capacity-scheduler.xml f1d4b48 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/capacity-scheduler.xml fd9980c 
>   ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_1.3_to_2.2.json d5087c3 
>   ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.0_to_2.2.2.json cc4400a 
>   ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.0_to_2.2.4.json 89c732a 
>   ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.1_to_2.2.2.json 017fb73 
>   ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.1_to_2.2.4.json 17f9030 
> 
> Diff: https://reviews.apache.org/r/38724/diff/
> 
> 
> Testing
> -------
> 
> I've removed properties from 2.2 stack, and also removed overrides from 2.3 stack. On both stacks, properties are absent after deployment and service checks pass
> Also I've checked manual upgrade 2.1->2.2, and 2.2->2.3
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>