You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Deep Singh <de...@gmail.com> on 2020/12/14 19:01:59 UTC
Review Request 73084: ATLAS-4067 In Entity Audits tab,
show action as "user-defined properties added/updated/deleted" instead of
plain 'Entity Updated'
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73084/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
Bugs: ATLAS-4067
https://issues.apache.org/jira/browse/ATLAS-4067
Repository: atlas
Description
-------
Unlike business attributes, custom(user-defined) attirbutes doesnot have exclusive CURD APIs. Custome attributes are modified using Entity update POST call only.As of today in the post call for modifying CA(custom attributes), there is no other changes in entity definition besides modified CA. However, entity update POST call can potentially have other updates as well. To address this issue, in this fix we try to find out if the update is only about CA if not we consider it regular Entity update call.
Ideally there should be a separate APIs for handling CA as we do have for BA(Business Attributes). In entity update call it is very difficult to find out if the call was for (CREAT, UPDATE, or DELETE) of a particular CA. Same is true for BA as well of BA modification are sent using ENtity Update API. Therefor untill we have separate APIs for handling CA we will be showing "User-defined Attribute(s) Updated" in the UI for any modification in CA
Diffs
-----
dashboardv2/public/js/utils/Enums.js ebfcebab1
dashboardv3/public/js/utils/Enums.js ebfcebab1
intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java 553870278
intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java c37e28238
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java ca6f373e0
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java b80e42eed
server-api/src/main/java/org/apache/atlas/RequestContext.java 32ffddde1
Diff: https://reviews.apache.org/r/73084/diff/1/
Testing
-------
Manual Testing was done.
Thanks,
Deep Singh
Re: Review Request 73084: ATLAS-4067 In Entity Audits tab,
show action as "user-defined properties added/updated/deleted" instead of
plain 'Entity Updated'
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73084/#review222358
-----------------------------------------------------------
Ship it!
Ship It!
- Ashutosh Mestry
On Dec. 16, 2020, 5:35 p.m., Deep Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73084/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2020, 5:35 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4067
> https://issues.apache.org/jira/browse/ATLAS-4067
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Unlike business attributes, custom(user-defined) attirbutes doesnot have exclusive CURD APIs. Custome attributes are modified using Entity update POST call only.As of today in the post call for modifying CA(custom attributes), there is no other changes in entity definition besides modified CA. However, entity update POST call can potentially have other updates as well. To address this issue, in this fix we try to find out if the update is only about CA if not we consider it regular Entity update call.
>
> Ideally there should be a separate APIs for handling CA as we do have for BA(Business Attributes). In entity update call it is very difficult to find out if the call was for (CREAT, UPDATE, or DELETE) of a particular CA. Same is true for BA as well of BA modification are sent using ENtity Update API. Therefor untill we have separate APIs for handling CA we will be showing "User-defined Attribute(s) Updated" in the UI for any modification in CA
>
>
> Diffs
> -----
>
> dashboardv2/public/js/utils/Enums.js ebfcebab1
> dashboardv3/public/js/utils/Enums.js ebfcebab1
> intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java 553870278
> intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java c37e28238
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java ca6f373e0
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java b80e42eed
> server-api/src/main/java/org/apache/atlas/RequestContext.java 32ffddde1
>
>
> Diff: https://reviews.apache.org/r/73084/diff/2/
>
>
> Testing
> -------
>
> Manual Testing was done.
>
>
> Thanks,
>
> Deep Singh
>
>
Re: Review Request 73084: ATLAS-4067 In Entity Audits tab,
show action as "user-defined properties added/updated/deleted" instead of
plain 'Entity Updated'
Posted by Deep Singh <de...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73084/
-----------------------------------------------------------
(Updated Dec. 16, 2020, 5:35 p.m.)
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
Bugs: ATLAS-4067
https://issues.apache.org/jira/browse/ATLAS-4067
Repository: atlas
Description
-------
Unlike business attributes, custom(user-defined) attirbutes doesnot have exclusive CURD APIs. Custome attributes are modified using Entity update POST call only.As of today in the post call for modifying CA(custom attributes), there is no other changes in entity definition besides modified CA. However, entity update POST call can potentially have other updates as well. To address this issue, in this fix we try to find out if the update is only about CA if not we consider it regular Entity update call.
Ideally there should be a separate APIs for handling CA as we do have for BA(Business Attributes). In entity update call it is very difficult to find out if the call was for (CREAT, UPDATE, or DELETE) of a particular CA. Same is true for BA as well of BA modification are sent using ENtity Update API. Therefor untill we have separate APIs for handling CA we will be showing "User-defined Attribute(s) Updated" in the UI for any modification in CA
Diffs (updated)
-----
dashboardv2/public/js/utils/Enums.js ebfcebab1
dashboardv3/public/js/utils/Enums.js ebfcebab1
intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java 553870278
intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java c37e28238
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java ca6f373e0
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java b80e42eed
server-api/src/main/java/org/apache/atlas/RequestContext.java 32ffddde1
Diff: https://reviews.apache.org/r/73084/diff/2/
Changes: https://reviews.apache.org/r/73084/diff/1-2/
Testing
-------
Manual Testing was done.
Thanks,
Deep Singh