You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2008/07/18 20:00:31 UTC
[jira] Commented: (HADOOP-3549) meaningful errno values in libhdfs
[ https://issues.apache.org/jira/browse/HADOOP-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614828#action_12614828 ]
Hadoop QA commented on HADOOP-3549:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12383981/libhdfs-03-combined.patch
against trunk revision 677872.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2903/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2903/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2903/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2903/console
This message is automatically generated.
> meaningful errno values in libhdfs
> ----------------------------------
>
> Key: HADOOP-3549
> URL: https://issues.apache.org/jira/browse/HADOOP-3549
> Project: Hadoop Core
> Issue Type: Improvement
> Components: libhdfs
> Affects Versions: 0.17.1
> Environment: any POSIX
> Reporter: Ben Slusky
> Assignee: Ben Slusky
> Attachments: libhdfs-01-exception-handling.patch, libhdfs-02-meaningful-errno.patch, libhdfs-03-combined.patch
>
>
> A comment near the top of hdfs.h says that "All APIs set errno to meaningful values." Unfortunately this is a big fat lie -- bigger and fatter still now that we have permissions in HDFS. If Hadoop throws an AccessControlException, then libhdfs sets errno to EINTERNAL, even though this is not an "internal" error in any sense of the word.
> With the attached patches, allow libhdfs to derive a useful errno value when an exception is thrown. I've implemented handling for AccessControlException and a few others whose semantics seem obvious.
> Tangential question: The signatures for invokeMethod() and constructNewObjectOfClass() in hdfsJniHelper.h disagreed with their comments. Was the "exc" argument of those functions removed in the past, or never implemented? I (re)instated it in my patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.