You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/01 23:51:09 UTC
[GitHub] [spark] amaliujia opened a new pull request, #38475: [SPARK-40992][CONNECT] Support toDF(columnNames) in Connect DSL
amaliujia opened a new pull request, #38475:
URL: https://github.com/apache/spark/pull/38475
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Add `RenameColumns` to proto to support the implementation for `toDF(columnNames: String*)` which renames the input relation to a different set of column names.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Improve API coverage.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #38475: [SPARK-40992][CONNECT] Support toDF(columnNames) in Connect DSL
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on code in PR #38475:
URL: https://github.com/apache/spark/pull/38475#discussion_r1011238884
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -123,6 +125,24 @@ class SparkConnectPlanner(plan: proto.Relation, session: SparkSession) {
logical.Range(start, end, step, numPartitions)
}
+ private def transformRenameColumns(rel: proto.RenameColumns): LogicalPlan = {
+ val input = new QueryExecution(session, transformRelation(rel.getInput)).analyzed
+ if (input.schema.size != rel.getColumnNamesCount) {
+ throw InvalidPlanInput(
+ "The number of columns doesn't match.\n" +
+ s"Old column names (${input.schema.size}): "
+ + input.schema.fields.map(_.name).mkString(", ") + "\n" +
+ s"New column names (${rel.getColumnNamesCount}): "
+ + rel.getColumnNamesList.asScala.mkString(", "))
+ }
+
+ val newCols =
+ input.output.zip(rel.getColumnNamesList.asScala).map { case (oldAttribute, newName) =>
+ Alias(oldAttribute, newName)()
+ }
+ logical.Project(newCols, input)
Review Comment:
i guess this can be simpler:
```
Dataset.ofRows(session, transformRelation(rel.getInput)).toDF(rel.getColumnNamesList.asScala).logicalPlan
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #38475: [SPARK-40992][CONNECT] Support toDF(columnNames) in Connect DSL
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on code in PR #38475:
URL: https://github.com/apache/spark/pull/38475#discussion_r1012465284
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -123,6 +125,24 @@ class SparkConnectPlanner(plan: proto.Relation, session: SparkSession) {
logical.Range(start, end, step, numPartitions)
}
+ private def transformRenameColumns(rel: proto.RenameColumns): LogicalPlan = {
+ val input = new QueryExecution(session, transformRelation(rel.getInput)).analyzed
+ if (input.schema.size != rel.getColumnNamesCount) {
+ throw InvalidPlanInput(
+ "The number of columns doesn't match.\n" +
+ s"Old column names (${input.schema.size}): "
+ + input.schema.fields.map(_.name).mkString(", ") + "\n" +
+ s"New column names (${rel.getColumnNamesCount}): "
+ + rel.getColumnNamesList.asScala.mkString(", "))
+ }
+
+ val newCols =
+ input.output.zip(rel.getColumnNamesList.asScala).map { case (oldAttribute, newName) =>
+ Alias(oldAttribute, newName)()
+ }
+ logical.Project(newCols, input)
Review Comment:
`toDF(rel.getColumnNamesList.asScala: _*)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #38475: [SPARK-40992][CONNECT] Support toDF(columnNames) in Connect DSL
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on code in PR #38475:
URL: https://github.com/apache/spark/pull/38475#discussion_r1017629761
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -274,3 +275,14 @@ message StatFunction {
}
}
+// Rename columns on the input relation.
Review Comment:
i just notice that we have a public api `DataFrame.withColumnsRenamed`, maybe change the name of the message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #38475: [SPARK-40992][CONNECT] Support toDF(columnNames) in Connect DSL
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38475:
URL: https://github.com/apache/spark/pull/38475#issuecomment-1299371686
@cloud-fan
This is a good example that one API can be implemented with or without a plan.
Basically if we don't add a new plan to the proto, clients can still implement `toDF(columnNames)` by two RPC calls:
1. The client needs to get the child input proto plan resolved by the server.
2. The client does necessary check (e.g. equal length column names) based on the result of 1.
3. The client construct a Project with all the input column names wrapped by column alias, with unresolved child input proto plan again.
Actually I don't know if the 3. will work. Literally we need to know the schema/output of the child input plan, then we get names from there, wrap such names by alias. Lastly we need analyzer to understand those name are from the child input and then apply those alias (replace those names with right attributes from the input plan).
Even 3. will work, this alternatively is more like pushing implementation load to the client (which is more than one client in most of the cases). Because of that, I am proposing just to have a plan in proto for this purpose.
Lastly, we are still matching API in proto and the DataFrame API is stable, thus it is not hurting longer term maintainability for the Connect proto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #38475: [SPARK-40992][CONNECT] Support toDF(columnNames) in Connect DSL
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on code in PR #38475:
URL: https://github.com/apache/spark/pull/38475#discussion_r1011300086
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -250,3 +251,15 @@ message SubqueryAlias {
// Optional. Qualifier of the alias.
repeated string qualifier = 3;
}
+
+// Rename columns on the input relation.
+message RenameColumns {
Review Comment:
i am afraid we have to add a logical for nearly each df API, even for simple functions like `toDF` ( as well as `withColumn`, [`dropDuplicates`](https://github.com/apache/spark/commit/b14da8b1b65d9f00f49fab87f738715089bc43e8)) which depend on analyzed plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #38475: [SPARK-40992][CONNECT] Support toDF(columnNames) in Connect DSL
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #38475:
URL: https://github.com/apache/spark/pull/38475#issuecomment-1301480681
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38475: [SPARK-40992][CONNECT] Support toDF(columnNames) in Connect DSL
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38475:
URL: https://github.com/apache/spark/pull/38475#discussion_r1018278902
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -274,3 +275,14 @@ message StatFunction {
}
}
+// Rename columns on the input relation.
Review Comment:
Let me take a look on the `DataFrame.withColumnsRenamed`. I am thinking if that API can re-use this message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #38475: [SPARK-40992][CONNECT] Support toDF(columnNames) in Connect DSL
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #38475:
URL: https://github.com/apache/spark/pull/38475#issuecomment-1299635038
if we try to implement it in the client side, another problem is that it's likely to reuse and depend on some functionality in `pyspark/sql`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38475: [SPARK-40992][CONNECT] Support toDF(columnNames) in Connect DSL
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38475:
URL: https://github.com/apache/spark/pull/38475#discussion_r1012449031
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -250,3 +251,15 @@ message SubqueryAlias {
// Optional. Qualifier of the alias.
repeated string qualifier = 3;
}
+
+// Rename columns on the input relation.
+message RenameColumns {
Review Comment:
I think as of now we are leaning to not adding new catalyst plan.
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -250,3 +251,15 @@ message SubqueryAlias {
// Optional. Qualifier of the alias.
repeated string qualifier = 3;
}
+
+// Rename columns on the input relation.
+message RenameColumns {
Review Comment:
I think as of now we are leaning to not add new catalyst plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #38475: [SPARK-40992][CONNECT] Support toDF(columnNames) in Connect DSL
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #38475:
URL: https://github.com/apache/spark/pull/38475#issuecomment-1308344423
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38475: [SPARK-40992][CONNECT] Support toDF(columnNames) in Connect DSL
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38475:
URL: https://github.com/apache/spark/pull/38475#discussion_r1012464469
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -123,6 +125,24 @@ class SparkConnectPlanner(plan: proto.Relation, session: SparkSession) {
logical.Range(start, end, step, numPartitions)
}
+ private def transformRenameColumns(rel: proto.RenameColumns): LogicalPlan = {
+ val input = new QueryExecution(session, transformRelation(rel.getInput)).analyzed
+ if (input.schema.size != rel.getColumnNamesCount) {
+ throw InvalidPlanInput(
+ "The number of columns doesn't match.\n" +
+ s"Old column names (${input.schema.size}): "
+ + input.schema.fields.map(_.name).mkString(", ") + "\n" +
+ s"New column names (${rel.getColumnNamesCount}): "
+ + rel.getColumnNamesList.asScala.mkString(", "))
+ }
+
+ val newCols =
+ input.output.zip(rel.getColumnNamesList.asScala).map { case (oldAttribute, newName) =>
+ Alias(oldAttribute, newName)()
+ }
+ logical.Project(newCols, input)
Review Comment:
Correct me if I am wrong:
`toDF(String*)` has a varargs parameter and I found there is no way to pass a list/seq to it. We need update API to `toDF(String_*)`. Will this make it become a API change we probably shouldn't do it now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38475: [SPARK-40992][CONNECT] Support toDF(columnNames) in Connect DSL
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38475:
URL: https://github.com/apache/spark/pull/38475#discussion_r1012477099
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -123,6 +125,24 @@ class SparkConnectPlanner(plan: proto.Relation, session: SparkSession) {
logical.Range(start, end, step, numPartitions)
}
+ private def transformRenameColumns(rel: proto.RenameColumns): LogicalPlan = {
+ val input = new QueryExecution(session, transformRelation(rel.getInput)).analyzed
+ if (input.schema.size != rel.getColumnNamesCount) {
+ throw InvalidPlanInput(
+ "The number of columns doesn't match.\n" +
+ s"Old column names (${input.schema.size}): "
+ + input.schema.fields.map(_.name).mkString(", ") + "\n" +
+ s"New column names (${rel.getColumnNamesCount}): "
+ + rel.getColumnNamesList.asScala.mkString(", "))
+ }
+
+ val newCols =
+ input.output.zip(rel.getColumnNamesList.asScala).map { case (oldAttribute, newName) =>
+ Alias(oldAttribute, newName)()
+ }
+ logical.Project(newCols, input)
Review Comment:
Done thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #38475: [SPARK-40992][CONNECT] Support toDF(columnNames) in Connect DSL
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #38475: [SPARK-40992][CONNECT] Support toDF(columnNames) in Connect DSL
URL: https://github.com/apache/spark/pull/38475
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip commented on pull request #38475: [SPARK-40992][CONNECT] Support toDF(columnNames) in Connect DSL
Posted by GitBox <gi...@apache.org>.
grundprinzip commented on PR #38475:
URL: https://github.com/apache/spark/pull/38475#issuecomment-1302731774
Yes, my probably my question is if (1) will work and we don't have to do heavy lifting? Once you did (1) and have the schema you could wrap the input plan with the select.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #38475: [SPARK-40992][CONNECT] Support toDF(columnNames) in Connect DSL
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #38475:
URL: https://github.com/apache/spark/pull/38475#discussion_r1011251487
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -250,3 +251,15 @@ message SubqueryAlias {
// Optional. Qualifier of the alias.
repeated string qualifier = 3;
}
+
+// Rename columns on the input relation.
+message RenameColumns {
Review Comment:
We definitely need this proto message, and we can probably add a corresponding logical if https://github.com/apache/spark/pull/38395 is the right direction.
cc @HyukjinKwon
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -250,3 +251,15 @@ message SubqueryAlias {
// Optional. Qualifier of the alias.
repeated string qualifier = 3;
}
+
+// Rename columns on the input relation.
+message RenameColumns {
Review Comment:
We definitely need this proto message, and we can probably add a corresponding logical plan if https://github.com/apache/spark/pull/38395 is the right direction.
cc @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip commented on pull request #38475: [SPARK-40992][CONNECT] Support toDF(columnNames) in Connect DSL
Posted by GitBox <gi...@apache.org>.
grundprinzip commented on PR #38475:
URL: https://github.com/apache/spark/pull/38475#issuecomment-1302724487
@amaliujia quick question, looking at the code in Dataset, why do we actually need to implement this on the server? The renaming could in theory be rewritten into a select with aliases, this would not require any server side changes and would be more true to the intent.
@cloud-fan @hvanhovell what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #38475: [SPARK-40992][CONNECT] Support toDF(columnNames) in Connect DSL
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38475:
URL: https://github.com/apache/spark/pull/38475#issuecomment-1302727166
To have select with alias, we need to know the previous schema first. I think it is covered by my previous comment if you were talking about the same thing https://github.com/apache/spark/pull/38475#issuecomment-1299371686?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org