You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "nooberfsh (via GitHub)" <gi...@apache.org> on 2023/10/10 03:09:27 UTC
[PR] AVRO-3881: [rust] Writer should write user metadata even if the body is empty [avro]
nooberfsh opened a new pull request, #2545:
URL: https://github.com/apache/avro/pull/2545
## What is the purpose of the change
Fix AVRO-3881
## Verifying this change
This change added test that `Writer` always write user metadata even if the body is empty.
## Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3881: [rust] Writer should write user metadata even if the body is empty [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g merged PR #2545:
URL: https://github.com/apache/avro/pull/2545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3881: [rust] Writer should write user metadata even if the body is empty [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on code in PR #2545:
URL: https://github.com/apache/avro/pull/2545#discussion_r1351641097
##########
lang/rust/avro/src/writer.rs:
##########
@@ -1139,6 +1141,22 @@ mod tests {
Ok(())
}
+ #[test]
+ fn test_empty_body() -> TestResult {
Review Comment:
```suggestion
fn test_avro_3881_metadata_empty_body() -> TestResult {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3881: [rust] Writer should write user metadata even if the body is empty [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #2545:
URL: https://github.com/apache/avro/pull/2545#issuecomment-1754569872
Thank you, @nooberfsh !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org