You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/08/17 05:57:08 UTC
[GitHub] [skywalking] CalbeeMing0530 opened a new issue #5329: The plugin of skywalking agent does not support collecting http header details, such as referer, user-agent, if-none-match, cookie, payload, etc.
CalbeeMing0530 opened a new issue #5329:
URL: https://github.com/apache/skywalking/issues/5329
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [x] Question or discussion
- [ ] Bug
- [ ] Requirement
- [x] Feature or performance improvement
___
### Question
- What do you want to know?
**I want to ask the following questions first:**
Does the skywalking java agent have a plugin that can collects the metadata of the http request header and can access it through the UI or elasticsearch? I have not found the relevant configuration by checking the agent.config file.
**Some findings through operating the UI:**
I can see the method and request url fields of the http header through the tracking function of the UI, and I can get the parameters carried in the http request url by modifying
`plugin.springmvc.collect_http_params=${SW_COLLECT_HTTP_PARAMS:true}`
as shown in the following figure:
So I think that skywalking should be able to get the detailed information of the http header. Is the skywalking UI unable to display this information now? Or need to be obtained through other methods?
___
### Requirement or improvement
- Please describe your requirements or improvement suggestions.
If skywalking does not provide this function by default, do you consider adding it in later development? I think this function is still needed when doing microservice traffic data collection.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5329: The plugin of skywalking agent does not support collecting http header details, such as referer, user-agent, if-none-match, cookie, payload, etc.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5329:
URL: https://github.com/apache/skywalking/issues/5329#issuecomment-675244422
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5329: The plugin of skywalking agent does not support collecting http header details, such as referer, user-agent, if-none-match, cookie, payload, etc.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5329:
URL: https://github.com/apache/skywalking/issues/5329#issuecomment-674674359
It is not supported, but you could contribute this feature. And like parameter collection mechanism, this should be optional.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on issue #5329: The plugin of skywalking agent does not support collecting http header details, such as referer, user-agent, if-none-match, cookie, payload, etc.
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #5329:
URL: https://github.com/apache/skywalking/issues/5329#issuecomment-675260845
For the headers part, it maybe contains senstive data, such as token, or userInfo related. shoud we add option choose to filter by header names?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5329: The plugin of skywalking agent does not support collecting http header details, such as referer, user-agent, if-none-match, cookie, payload, etc.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5329:
URL: https://github.com/apache/skywalking/issues/5329#issuecomment-675286197
Yes, we have to, in order to avoid security leak as you said, and overload the agent and storage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on issue #5329: The plugin of skywalking agent does not support collecting http header details, such as referer, user-agent, if-none-match, cookie, payload, etc.
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #5329:
URL: https://github.com/apache/skywalking/issues/5329#issuecomment-675294316
Yes, I agree
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5329: The plugin of skywalking agent does not support collecting http header details, such as referer, user-agent, if-none-match, cookie, payload, etc.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5329:
URL: https://github.com/apache/skywalking/issues/5329#issuecomment-675286533
Such as cookie is a sensitive thing, which we should not collect in default, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 closed issue #5329: The plugin of skywalking agent does not support collecting http header details, such as referer, user-agent, if-none-match, cookie, payload, etc.
Posted by GitBox <gi...@apache.org>.
kezhenxu94 closed issue #5329:
URL: https://github.com/apache/skywalking/issues/5329
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui edited a comment on issue #5329: The plugin of skywalking agent does not support collecting http header details, such as referer, user-agent, if-none-match, cookie, payload, etc.
Posted by GitBox <gi...@apache.org>.
xbkaishui edited a comment on issue #5329:
URL: https://github.com/apache/skywalking/issues/5329#issuecomment-675260845
For the headers part, it maybe contains sensitive data, such as token, or userInfo related. shoud we add option choose to filter by header names?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on issue #5329: The plugin of skywalking agent does not support collecting http header details, such as referer, user-agent, if-none-match, cookie, payload, etc.
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #5329:
URL: https://github.com/apache/skywalking/issues/5329#issuecomment-675239448
I want to try, please assign to me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org