You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "hussein-awala (via GitHub)" <gi...@apache.org> on 2023/03/05 02:29:53 UTC
[GitHub] [airflow] hussein-awala opened a new pull request, #29925: Fix BigQueryToGCSOperator by waiting insert_job result in normal mode
hussein-awala opened a new pull request, #29925:
URL: https://github.com/apache/airflow/pull/29925
closes: #29912
---
In deferrable mode, we should not wait the job result in the worker, instead we create a trigger and we wait the end of the job in the triggerer, and this is what we do currently. But in the normal mode, we should wait it in the worker, otherwise the task finishes immediately with success state regardless the state of the job and its duration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #29925: Fix BigQueryToGCSOperator by waiting insert_job result in normal mode
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #29925:
URL: https://github.com/apache/airflow/pull/29925
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29925: Fix BigQueryToGCSOperator by waiting insert_job result in normal mode
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29925:
URL: https://github.com/apache/airflow/pull/29925#issuecomment-1455023689
BTW. @Taragolis seems we have the docker-compose flaky test back :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29925: Fix BigQueryToGCSOperator by waiting insert_job result in normal mode
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29925:
URL: https://github.com/apache/airflow/pull/29925#issuecomment-1455024372
Ah. No. Seems that is side effect of the "importilb 5.0.0" issue : https://github.com/apache/airflow/pull/29924.
It should be fine now after it's merged. Let me rebase and try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] benjyblack commented on pull request #29925: Fix BigQueryToGCSOperator by waiting insert_job result in normal mode
Posted by "benjyblack (via GitHub)" <gi...@apache.org>.
benjyblack commented on PR #29925:
URL: https://github.com/apache/airflow/pull/29925#issuecomment-1455129901
@hussein-awala thanks for fixing this so quickly!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org