You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/04/16 18:56:25 UTC

[GitHub] [incubator-tvm] zhiics opened a new issue #5351: [Jenkinsfile] Should we include libvta_tsim.so at the top level

zhiics opened a new issue #5351: [Jenkinsfile] Should we include libvta_tsim.so at the top level
URL: https://github.com/apache/incubator-tvm/issues/5351
 
 
   @tqchen @tmoreau89 
   
   Should we include libvta_tsim.so and libvta_fsim.so here?
   
   https://github.com/apache/incubator-tvm/blob/84d1eec39a10c559cb659d3f411cacce08cfdaff/Jenkinsfile#L56-L57
   
   it looks we should set them on in the CPU script, but not GPU
   https://github.com/apache/incubator-tvm/blob/84d1eec39a10c559cb659d3f411cacce08cfdaff/tests/scripts/task_config_build_cpu.sh#L39-L40
   
   However, we will use them here when we build GPU here
   https://github.com/apache/incubator-tvm/blob/84d1eec39a10c559cb659d3f411cacce08cfdaff/Jenkinsfile#L148
   
   CC @trevor-m 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] zhiics closed issue #5351: [Jenkinsfile] Should we include libvta_tsim.so at the top level

Posted by GitBox <gi...@apache.org>.
zhiics closed issue #5351: [Jenkinsfile] Should we include libvta_tsim.so at the top level
URL: https://github.com/apache/incubator-tvm/issues/5351
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen commented on issue #5351: [Jenkinsfile] Should we include libvta_tsim.so at the top level

Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5351: [Jenkinsfile] Should we include libvta_tsim.so at the top level
URL: https://github.com/apache/incubator-tvm/issues/5351#issuecomment-614846263
 
 
   I agree, please send a patch :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] zhiics commented on issue #5351: [Jenkinsfile] Should we include libvta_tsim.so at the top level

Posted by GitBox <gi...@apache.org>.
zhiics commented on issue #5351: [Jenkinsfile] Should we include libvta_tsim.so at the top level
URL: https://github.com/apache/incubator-tvm/issues/5351#issuecomment-614929802
 
 
   close by #5352 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] zhiics edited a comment on issue #5351: [Jenkinsfile] Should we include libvta_tsim.so at the top level

Posted by GitBox <gi...@apache.org>.
zhiics edited a comment on issue #5351: [Jenkinsfile] Should we include libvta_tsim.so at the top level
URL: https://github.com/apache/incubator-tvm/issues/5351#issuecomment-614841035
 
 
   I see. Thanks. Then should we add `set(USE_VTA_TSIM/FSIM, ON)` in the build_gpu.sh? We see errors when packing the lib for GPU

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen commented on issue #5351: [Jenkinsfile] Should we include libvta_tsim.so at the top level

Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5351: [Jenkinsfile] Should we include libvta_tsim.so at the top level
URL: https://github.com/apache/incubator-tvm/issues/5351#issuecomment-614839000
 
 
   we still need them for building vta tutorials, which is in the last docs stage

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] zhiics commented on issue #5351: [Jenkinsfile] Should we include libvta_tsim.so at the top level

Posted by GitBox <gi...@apache.org>.
zhiics commented on issue #5351: [Jenkinsfile] Should we include libvta_tsim.so at the top level
URL: https://github.com/apache/incubator-tvm/issues/5351#issuecomment-614841035
 
 
   I see. Thanks. Then should we add `set(USE_VTA_TSIM/FSIM, ON)` in the build_gpu.sh? We see errors when packing the lib

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services