You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/09/30 05:02:13 UTC

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #922: ORC-1013: Renaming the object of WriterContext in all TreeWriter's derived class

dongjoon-hyun commented on a change in pull request #922:
URL: https://github.com/apache/orc/pull/922#discussion_r719059436



##########
File path: java/core/src/java/org/apache/orc/OrcFile.java
##########
@@ -691,7 +691,7 @@ public WriterOptions physicalWriter(PhysicalWriter writer) {
     }
 
     /**
-     * A package local option to set the memory manager.
+     * A public option to set the memory manager.

Review comment:
       We usually don't mix like this. Especially, this minor change exists in an independent file. Please revert this. You can do this later in another PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org