You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/08 02:57:05 UTC

[GitHub] [spark] dongjoon-hyun commented on pull request #35422: [SPARK-36061][K8S] Add Volcano feature step and enable user specified minimum resources

dongjoon-hyun commented on pull request #35422:
URL: https://github.com/apache/spark/pull/35422#issuecomment-1032160715


   Thanks. You can make separate PRs, but you cannot make an intermediate namespace `min` here according to your plan.
   You need to change like `min.cpu` -> `minCpu`, `min.memory` -> `minMemory`.  In addition, `member` looks too general to be used in that context. Please revise to the more meaningful name.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org