[jira] [Issue Comment Edited] (CXF-3988) org.apache.cxf.jaxrs.ext.multipart.Attachment object should be mutable

["Sergey Beryozkin (Issue Comment Edited) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CXF-3988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174072#comment-13174072 ] 

Sergey Beryozkin edited comment on CXF-3988 at 12/21/11 1:04 PM:
-----------------------------------------------------------------

Sounds like a good idea indeed;
Something like 
{code:java}
AttachmentBuilder {
   AttachmentBuilder header(String name, Object value);
   // shortcut for header ("Content-Disposition", cd)
   AttachmentBuilder cd(ContentDisposition cd);   
   AttachmentBuilder data(InputStream is);
   // etc
   Attachment build();
} 
{code}
guess something like that can be handy, it may take a bit of time to make it complete, but I like the idea 

                
      was (Author: sergey_beryozkin):
    Sounds like a good idea indeed;
Something like 
AttachmentBuilder {
   AttachmentBuilder header(String name, Object value);
   // shortcut for header ("Content-Disposition", cd)
   AttachmentBuilder cd(ContentDisposition cd);   
   AttachmentBuilder data(InputStream is);
   // etc
   Attachment build();
} 
guess something like that can be handy, it may take a bit of time to make it complete, but I like the idea 

                  
> org.apache.cxf.jaxrs.ext.multipart.Attachment object should be mutable
> ----------------------------------------------------------------------
>
>                 Key: CXF-3988
>                 URL: https://issues.apache.org/jira/browse/CXF-3988
>             Project: CXF
>          Issue Type: Improvement
>          Components: JAX-RS
>    Affects Versions: 2.5.1
>            Reporter: Benson Margulies
>
> As currently coded, the headers in an Attachment are immutable after construction. This prevents a construction like:
>     - call a convenient constructor
>     - add one more header
> Rather than change the contract of getHeaders, I propose to add put/putSingle to the contract of Attachment.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira