RE: [PATCH/RFC] use-sasl=true in --without-sasl builds: make that a fatalerror?

[Bert Huijben <be...@qqmail.nl>]

Isn’t this a documented default value?

If it is, changing the behavior will likely break many users that don’t use sasl.

Bert

Sent from my Windows 10 phone

From: Daniel Shahaf
Sent: zaterdag 30 april 2016 02:53
To: dev@subversion.apache.org
Subject: [PATCH/RFC] use-sasl=true in --without-sasl builds: make that a fatalerror?

Currently, if use-sasl=true is set in svnserve.conf but svnserve was
compiled without SASL support, SASL is silently not used.  That's
actually documented:

  svnserve.conf:
    [sasl]
    ### This option specifies whether you want to use the Cyrus SASL
    ### library for authentication. Default is false.
    ### This section will be ignored if svnserve is not built with Cyrus
    ### SASL support; to check, run 'svnserve --version' and look for a line
    ### reading 'Cyrus SASL authentication is available.'
    # use-sasl = true

But documentation notwithstanding, it seems like a misfeature.  Should
we change this, so --without-sasl builds will error out if use-sasl=true
is set?  The patch would be simple enough (attached).

Cheers,

Daniel

P.S. The 'password-db' setting is in the same boat: it's ignored
when SASL is enabled, and documented this way.  However, I'm not
convinced a change to that setting's handling is needed.

Re: [PATCH/RFC] use-sasl=true in --without-sasl builds: make that a fatalerror?

[Daniel Shahaf <d....@daniel.shahaf.name>]

Bert Huijben wrote on Sat, Apr 30, 2016 at 09:43:02 +0200:
> Isn\u2019t this a documented default value?
> 
> If it is, changing the behavior will likely break many users that don\u2019t use sasl.

The default for use-sasl is 'false', so the only possible breakage is
for users who uncommented the "# use-sasl = true" line and use
non-SVN_HAVE_SASL builds.