You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Gordon Sim <gs...@redhat.com> on 2012/10/12 18:36:14 UTC
Review Request: Expand AMQP protocol header related code to accomodate 1.0
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7563/
-----------------------------------------------------------
Review request for qpid.
Description
-------
Mainly needed for broker side to detect the different versions and to detect if a SASL layer has been requested.
This addresses bug QPID-4368.
https://issues.apache.org/jira/browse/QPID-4368
Diffs
-----
/trunk/qpid/cpp/include/qpid/framing/ProtocolVersion.h 1397295
/trunk/qpid/cpp/src/qpid/framing/ProtocolInitiation.cpp 1397295
/trunk/qpid/cpp/src/qpid/framing/ProtocolVersion.cpp 1397295
Diff: https://reviews.apache.org/r/7563/diff/
Testing
-------
Thanks,
Gordon Sim
Re: Review Request: Expand AMQP protocol header related code to accomodate
1.0
Posted by Gordon Sim <gs...@redhat.com>.
> On Oct. 12, 2012, 4:42 p.m., Steve Huston wrote:
> > In ProtocolVersion.cpp should the use of the numbers 2 and 3 be replaced by the defined constants for them?
Yes! I'll make that change.
- Gordon
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7563/#review12398
-----------------------------------------------------------
On Oct. 12, 2012, 4:36 p.m., Gordon Sim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7563/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2012, 4:36 p.m.)
>
>
> Review request for qpid.
>
>
> Description
> -------
>
> Mainly needed for broker side to detect the different versions and to detect if a SASL layer has been requested.
>
>
> This addresses bug QPID-4368.
> https://issues.apache.org/jira/browse/QPID-4368
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/include/qpid/framing/ProtocolVersion.h 1397295
> /trunk/qpid/cpp/src/qpid/framing/ProtocolInitiation.cpp 1397295
> /trunk/qpid/cpp/src/qpid/framing/ProtocolVersion.cpp 1397295
>
> Diff: https://reviews.apache.org/r/7563/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gordon Sim
>
>
Re: Review Request: Expand AMQP protocol header related code to accomodate
1.0
Posted by Steve Huston <sh...@riverace.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7563/#review12398
-----------------------------------------------------------
In ProtocolVersion.cpp should the use of the numbers 2 and 3 be replaced by the defined constants for them?
- Steve Huston
On Oct. 12, 2012, 4:36 p.m., Gordon Sim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7563/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2012, 4:36 p.m.)
>
>
> Review request for qpid.
>
>
> Description
> -------
>
> Mainly needed for broker side to detect the different versions and to detect if a SASL layer has been requested.
>
>
> This addresses bug QPID-4368.
> https://issues.apache.org/jira/browse/QPID-4368
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/include/qpid/framing/ProtocolVersion.h 1397295
> /trunk/qpid/cpp/src/qpid/framing/ProtocolInitiation.cpp 1397295
> /trunk/qpid/cpp/src/qpid/framing/ProtocolVersion.cpp 1397295
>
> Diff: https://reviews.apache.org/r/7563/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gordon Sim
>
>