You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@aurora.apache.org by Renan DelValle <re...@apache.org> on 2018/02/07 19:25:21 UTC

Re: Review Request 65433: Update Javascript Thrift to 0.10

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65433/#review197018
-----------------------------------------------------------


Ship it!




Applied the patch locally and brought up a task. Works fine. Good catch Stephan!

- Renan DelValle


On Jan. 31, 2018, 2:11 a.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65433/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2018, 2:11 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> We missed this change when bumping the Thrift version used by Python and
> Java. https://reviews.apache.org/r/64290/
> 
> List of changes: https://github.com/apache/thrift/commits/master/lib/js/src/thrift.js
> 
> 
> Diffs
> -----
> 
>   3rdparty/javascript/scheduler/assets/js/thrift.js 111518739a7d353433ad59b7e48c84c2dbb546db 
> 
> 
> Diff: https://reviews.apache.org/r/65433/diff/1/
> 
> 
> Testing
> -------
> 
> Manually verified that the UI is still working
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>