[GitHub] [incubator-brpc] wwbmmm commented on pull request #1958: limiting max bytes in stream comsume queue with the same host socket

[GitBox <gi...@apache.org>]

wwbmmm commented on PR #1958:
URL: https://github.com/apache/incubator-brpc/pull/1958#issuecomment-1286357409

   编译失败且有warning，@chenbay
   
   ```cpp
   src/brpc/stream.cpp:81:30: error: cannot assign to variable 'options' with
         const-qualified type 'const brpc::StreamOptions &'
           options.min_buf_size = 0;
           ~~~~~~~~~~~~~~~~~~~~ ^
   src/brpc/stream.cpp:68:41: note: variable 'options' declared const here
   int Stream::Create(const StreamOptions &options, 
                      ~~~~~~~~~~~~~~~~~~~~~^~~~~~~
   src/brpc/stream.cpp:326:117: warning: comparison of integers of different signs:
         'size_t' (aka 'unsigned long') and 'int' [-Wsign-compare]
     ...(_options.max_buf_size == 0 || _cur_buf_size < _options.max_buf_size)) {
                                       ~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
   src/brpc/stream.cpp:327:64: warning: comparison of integers of different signs:
         'unsigned long' and 'int' [-Wsign-compare]
     ...> 0 && _cur_buf_size * 2 > _options.max_buf_size) {
               ~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org