You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2012/08/02 03:40:04 UTC
[Bug 120437] New: Connector line does not shown correctly in grouped
object
https://issues.apache.org/ooo/show_bug.cgi?id=120437
Priority: P3
Bug ID: 120437
CC: Armin.Le.Grand@me.com
Assignee: ooo-issues@incubator.apache.org
Summary: Connector line does not shown correctly in grouped
object
Severity: normal
Issue Type: DEFECT
Classification: Application
OS: All
Reporter: lijianyuan1983@gmail.com
Hardware: All
Status: UNCONFIRMED
Version: AOO350-dev
Component: open-import
Product: drawing
Created attachment 78808
--> https://issues.apache.org/ooo/attachment.cgi?id=78808&action=edit
Test sample file for this issue
Reproduce step:
1. Import the sample file in AOO. It is a MS 2003 ppt file.
2. Check the import result. See the two jpg files in attachment.
Expect result: The imported connector line in group object should be the same
as in sample ppt file.
Actual result: Connector line with red bound is shown incorrectly. Its two ends
get away from the connection points of rectangular which is connected by it.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120437] [From Symphony]Connector line does not shown correctly
in grouped object
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120437
Jianyuan Li <li...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Connector line does not |[From Symphony]Connector
|shown correctly in grouped |line does not shown
|object |correctly in grouped object
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120437] Connector line does not shown correctly in grouped
object
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120437
liupingtan <do...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|VERIFIED |CLOSED
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120437] Connector line does not shown correctly in grouped
object
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120437
--- Comment #8 from Armin Le Grand <Ar...@me.com> ---
ALG @Jianyuan Li: When removing SdrEdgeObj::NbcRotate/NbcMirror/NbcShear the
trink AOO behaves like the AOO34 release. Does this fix the error from your
POV? I'm asking since even in AOO3.4 the connector(s) in question are not
nicely layouted and 'snap' when moving the group.
BTW: It has to do with bEdgeTrackUserDefined, a compatibility feature Sven
Jacobi had added once for PPT where the layouted paths of connectors get
imported.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120437] Connector line does not shown correctly in grouped
object
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120437
--- Comment #5 from Jianyuan Li <li...@gmail.com> ---
But for connector line in organization chart in attachment file "oc.ppt", the
change in filter(msdffimp.cxx) still does not work. Comparing its AOO import
result with the attachment "realgrouped.ppt", its connector line will not
become normal when drag the grouped object(for "realgrouped.ppt", dragging can
result in a normal connector line).
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120437] Connector line does not shown correctly in grouped
object
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120437
--- Comment #1 from Jianyuan Li <li...@gmail.com> ---
Created attachment 78809
--> https://issues.apache.org/ooo/attachment.cgi?id=78809&action=edit
Actual result 1
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120437] Connector line does not shown correctly in grouped
object
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120437
--- Comment #11 from Jianyuan Li <li...@gmail.com> ---
@Armin:
There is a concept "skew" in AOO(See connector configuration dialog). We can
adjust the imported connector line as one in MS 2003. Then its skew value will
be changed. So this value will impact the connector line drawing.
This concept does not exist in MS 2003. So filter does nothing for this
property. And core function will set a default value 0 for it.
I think this results in the issue. Symphony works well for this issue. In it,
nothing is set for skew value. Can the default value 0 be not set in AOO?
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120437] Connector line does not shown correctly in grouped
object
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120437
--- Comment #10 from Armin Le Grand <Ar...@me.com> ---
Created attachment 78841
--> https://issues.apache.org/ooo/attachment.cgi?id=78841&action=edit
Proposed patch to fix most problems
ALG @Jianyuan Li: Please have a look.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120437] Connector line does not shown correctly in grouped
object
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120437
liupingtan <do...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
CC| |doneyourself@gmail.com
--- Comment #21 from liupingtan <do...@gmail.com> ---
confirm on AOO350ml 1377620 on Win7-64bit
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120437] Connector line does not shown correctly in grouped
object
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120437
--- Comment #12 from Jianyuan Li <li...@gmail.com> ---
I think filter imports connector line edge path(with adjustment value)
correctly.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120437] Connector line does not shown correctly in grouped
object
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120437
--- Comment #4 from Jianyuan Li <li...@gmail.com> ---
The issue can be fixed by add some code in filter(msdffimp.cxx) for connector
line import.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120437] Connector line does not shown correctly in grouped
object
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120437
--- Comment #17 from Jianyuan Li <li...@gmail.com> ---
@Armin:
The second patch look very good:
1. The regression issue(fix for i54102, revision 1351648) is fixed.
2. The connector is layouted correctly:
_
|
|
instead of
_|
|
Thanks.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120437] Connector line does not shown correctly in grouped
object
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120437
--- Comment #15 from Armin Le Grand <Ar...@me.com> ---
ALG: Two more additions:
- in SdrEdgeObj::ConnectToNode reset bEdgeTrackUserDefined when really a
connection to an SdrObject gets set. This can no longer be a
EdgeTrackUserDefined case.
- in SdrEdgeObj::ImpRecalcEdgeTrack return always when bEdgeTrackUserDefined or
no model or model locked. This avoids reliably the overwriting of
bEdgeTrackUserDefined cases and their imported polygons (as the other cnages,
cannot have worked for quite some time).
With this changes both exampes work fine, example2 shows connector as in PPT.
Preparing extended patch.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120437] Connector line does not shown correctly in grouped
object
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120437
--- Comment #19 from SVN Robot <sv...@dev.null.org> ---
"alg" committed SVN revision 1369760 into trunk:
#120437# Connector corrections in groups and PPT imports
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120437] Connector line does not shown correctly in grouped
object
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120437
--- Comment #16 from Armin Le Grand <Ar...@me.com> ---
Created attachment 78842
--> https://issues.apache.org/ooo/attachment.cgi?id=78842&action=edit
New extended patch, replaces first one.
ALG @Jianyuan Li: Please have a look. Just use 2nd patch (this one), it
contains first one.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120437] Connector line does not shown correctly in grouped
object
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120437
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ACCEPTED |RESOLVED
Resolution|--- |FIXED
--- Comment #20 from Armin Le Grand <Ar...@me.com> ---
ALG: Found the place where the correction is needed, mirror flags were already
resetted. Added resetting rotation flag to not apply it twice. Built, tested,
works as expected. Result is as in comment17, checking in code, done in
revision 1369760.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120437] Connector line does not shown correctly in grouped
object
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120437
--- Comment #3 from Jianyuan Li <li...@gmail.com> ---
I am working on this issue.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120437] Connector line does not shown correctly in grouped
object
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120437
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |CONFIRMED
Ever confirmed|0 |1
--- Comment #7 from Armin Le Grand <Ar...@me.com> ---
ALG: Attachment 78808 (example1): Ungrouping corrects the connector.
Attachment 78827: The connector is not connected to the shapes at all, thus no
refresh on actions taken.
Taking a look...
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120437] Connector line does not shown correctly in grouped
object
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120437
--- Comment #13 from Jianyuan Li <li...@gmail.com> ---
I will check the patch later. A new code base is loaded and being built......
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120437] Connector line does not shown correctly in grouped
object
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120437
--- Comment #18 from Armin Le Grand <Ar...@me.com> ---
ALG: Need to change more. It is not okay to not transform the
bEdgeTrackUserDefined path because this is nee3ded for interactive editing
later. The error is not to transform the geometry, but that it gets transformed
when importing it. The PPT import filter has the knowledge that this
bEdgeTrackUserDefined path is in already transformed form and should not call
any transformations when importing.
Doing needed changes...
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120437] Connector line does not shown correctly in grouped
object
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120437
--- Comment #2 from Jianyuan Li <li...@gmail.com> ---
Created attachment 78810
--> https://issues.apache.org/ooo/attachment.cgi?id=78810&action=edit
Actual result 2
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120437] [From Symphony]Connector line does not shown correctly
in grouped object
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120437
Shenfeng Liu <li...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |liushenf@gmail.com
Target Milestone|--- |AOO 4.0
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120437] Connector line does not shown correctly in grouped
object
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120437
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |ACCEPTED
--- Comment #9 from Armin Le Grand <Ar...@me.com> ---
ALG: Connectors do not get relayouted for two reasons:
- In SdrModel::setLock calling ImpReformatAllEdgeObjects has no effect since
mbModelLocked is still on true (checked inside ImpReformatAllEdgeObjects).
- SdrObjList::ReformatAllEdgeObjects() goes currently only over the flat page
hierarchy, so connectors in groups will not be handled at all.
When correcting both, example1 loads well, it's connectors are not really
bEdgeTrackUserDefined, they get connections set for both ends.
Example2 does not change. Closer looking shows that it is a real case of
bEdgeTrackUserDefined. When looking at the PPT file (in PPT) it can be seen
that the connector in question is hidden half behind object 3. If applying the
transformations to the imported edge track, the start and end point will be
correct, but still the connector is layouted as:
_|
|
instead of
_
|
|
This may be because the control point data (the offset controllers) do not get
imported, but I do not know for sure. Preparing proposed patch.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120437] Connector line does not shown correctly in grouped
object
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120437
--- Comment #6 from Jianyuan Li <li...@gmail.com> ---
Created attachment 78827
--> https://issues.apache.org/ooo/attachment.cgi?id=78827&action=edit
Another test sample file for this issue
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120437] Connector line does not shown correctly in grouped
object
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120437
--- Comment #14 from Armin Le Grand <Ar...@me.com> ---
ALG @Jianyuan Li: The skew value is zero (on default). This creates the
standard connector form. I am curious if it gets layouted at all, it should not
since it is a bEdgeTrackUserDefined case.
--
You are receiving this mail because:
You are the assignee for the bug.