You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2016/02/09 18:27:05 UTC

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1138 Improve messaging...

GitHub user spmallette opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/217

    TINKERPOP-1138 Improve messaging on server timeouts

    https://issues.apache.org/jira/browse/TINKERPOP-1138
    
    Provide distinct messaging for the different kinds of timeouts that Gremlin Server can generate.
    
    Tested with: `mvn clean install && mvn verify -pl gremlin-server -DskipIntegrationTests=false`
    
    VOTE: +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1138

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/217.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #217
    
----
commit 89e159b8bf9d4d6bcf6fc392dceb6c7eba33cf51
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2016-02-08T21:09:51Z

    Improved messaging from gremlin server around timeouts.
    
    There are multiple timeouts configurable in gremlin server and it wasn't always clear which was triggering given the error messages that were being generated.  Improved the clarity in server-side logging and in the messages returned to the client.

commit bad3af7ca2c57057995c4fb7f183bdc41f41ff72
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2016-02-09T16:58:23Z

    Merge remote-tracking branch 'origin/tp31' into TINKERPOP-1138

commit 330c521dc652582d2525419cedb2748ec0291be4
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2016-02-09T17:00:35Z

    Update changelog.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1138 Improve messaging...

Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/217#issuecomment-183508884
  
    VOTE +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1138 Improve messaging...

Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/217#issuecomment-182853321
  
    Code looks good, `mvn clean install` passed...
    
    VOTE: +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1138 Improve messaging...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-tinkerpop/pull/217


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---