You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "nastra (via GitHub)" <gi...@apache.org> on 2024/02/08 09:44:41 UTC

[PR] AWS: Add url-connection-client to aws-bundle [iceberg]

nastra opened a new pull request, #9685:
URL: https://github.com/apache/iceberg/pull/9685

   Without this, it's not possible to switch the underlying HTTP client via `http-client.type=urlconnection` (as defined in `HttpClientProperties`)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] AWS: Add url-connection-client to aws-bundle [iceberg]

Posted by "ismailsimsek (via GitHub)" <gi...@apache.org>.
ismailsimsek commented on PR #9685:
URL: https://github.com/apache/iceberg/pull/9685#issuecomment-1975274866

   +1 adding it. without this dependency getting following error
   
   `Caused by: java.lang.NoClassDefFoundError: com/amazonaws/event/ProgressListener`
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] AWS: Add url-connection-client to aws-bundle [iceberg]

Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra closed pull request #9685: AWS: Add url-connection-client to aws-bundle
URL: https://github.com/apache/iceberg/pull/9685


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] AWS: Add url-connection-client to aws-bundle [iceberg]

Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on PR #9685:
URL: https://github.com/apache/iceberg/pull/9685#issuecomment-1934536087

   I'll hold off merging this because there might be a separate issue when bundling this dependency according to @danielcweeks 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] AWS: Add url-connection-client to aws-bundle [iceberg]

Posted by "danielcweeks (via GitHub)" <gi...@apache.org>.
danielcweeks commented on PR #9685:
URL: https://github.com/apache/iceberg/pull/9685#issuecomment-1975284396

   I don't think we can include this by default. The issue is if client is ever created without explicitly setting the HTTP implementation and there are two implementations on the classpath, it will failed to initialize the client.  Even if we are diligent about setting the specific implementation in iceberg, this could break anything else using the SDK.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] AWS: Add url-connection-client to aws-bundle [iceberg]

Posted by "94Sip (via GitHub)" <gi...@apache.org>.
94Sip commented on PR #9685:
URL: https://github.com/apache/iceberg/pull/9685#issuecomment-1946981814

   I have used v1.4.3 with Glue jobs and simply referenced the url connection client in the --extra-jars job parameter and had no problems, and I used the `http-client.type=urlconnection` SparkConfig.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org