You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "liurenjie1024 (via GitHub)" <gi...@apache.org> on 2023/10/18 06:10:17 UTC
[PR] fix: Add catalog pages to docs. [iceberg-docs]
liurenjie1024 opened a new pull request, #284:
URL: https://github.com/apache/iceberg-docs/pull/284
Close https://github.com/apache/iceberg/issues/8850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: Add catalog pages to docs. [iceberg-docs]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on code in PR #284:
URL: https://github.com/apache/iceberg-docs/pull/284#discussion_r1366853709
##########
docs/content/catalog.md:
##########
@@ -1,7 +1,10 @@
---
Review Comment:
Cool, I'll fix that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: Add catalog pages to docs. [iceberg-docs]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on code in PR #284:
URL: https://github.com/apache/iceberg-docs/pull/284#discussion_r1366834493
##########
docs/content/catalog.md:
##########
@@ -1,7 +1,10 @@
---
Review Comment:
I moved it to doc on purpose since it seems that currently there is only once concept(e.g. catalog), and I feel better to put it in docs folder so that its position it is quite close to table. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: Add catalog pages to docs. [iceberg-docs]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on PR #284:
URL: https://github.com/apache/iceberg-docs/pull/284#issuecomment-1774361996
> Hi, @nastra I followed you instruction to add it, it goes well mostly but with one thing: <img alt="image" width="1519" src="https://user-images.githubusercontent.com/2771941/277220251-d83a7fe6-3e49-4837-86ad-df76f47a27c2.png">
>
> The headers are wrapped, do you know how to fix it? I'm not familiar with hugo.
Never mind, my friend helped me to solve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: Add catalog pages to docs. [iceberg-docs]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra merged PR #284:
URL: https://github.com/apache/iceberg-docs/pull/284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: Add catalog pages to docs. [iceberg-docs]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on PR #284:
URL: https://github.com/apache/iceberg-docs/pull/284#issuecomment-1772340731
I think the initial goal was to have a `Concepts` section on the website and that catalog page was the first page to be shown here. So I think what we want here is
```
diff --git a/landing-page/config.toml b/landing-page/config.toml
index f14d2ff1..9b0b4810 100644
--- a/landing-page/config.toml
+++ b/landing-page/config.toml
@@ -67,6 +67,8 @@ home = [ "HTML", "RSS", "SearchIndex" ]
{ name = "Multi-Engine Support", url = "/multi-engine-support", parent = "Project", weight = 450 },
{ name = "How To Release", parent = "Project", url = "/how-to-release", weight = 500 },
{ name = "Terms", url = "/terms", parent = "Project", weight = 600 },
+ { name = "Concepts", weight = 1150 },
+ { name = "Catalogs", url = "/concepts/catalog", parent = "Concepts", weight = 1160 },
{ name = "ASF", weight = 1200 },
{ name = "License", identifier = "_license", parent = "ASF", url = "https://www.apache.org/licenses/" },
{ name = "Security", identifier = "_security", parent = "ASF", url = "https://www.apache.org/security/" },
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: Add catalog pages to docs. [iceberg-docs]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #284:
URL: https://github.com/apache/iceberg-docs/pull/284#discussion_r1366846991
##########
docs/content/catalog.md:
##########
@@ -1,7 +1,10 @@
---
Review Comment:
it should stay under `common` IMO. We just need to make sure we properly link to that page
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: Add catalog pages to docs. [iceberg-docs]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #284:
URL: https://github.com/apache/iceberg-docs/pull/284#discussion_r1366657036
##########
docs/content/catalog.md:
##########
@@ -1,7 +1,10 @@
---
Review Comment:
I see that the file got moved out of the `common` directory. It should actually stay in that directory. Can you please move the file back?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: Add catalog pages to docs. [iceberg-docs]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on PR #284:
URL: https://github.com/apache/iceberg-docs/pull/284#issuecomment-1774360342
Hi, @nastra I followed you instruction to add it, it goes well mostly but with one thing:
<img width="1519" alt="image" src="https://github.com/apache/iceberg-docs/assets/2771941/d83a7fe6-3e49-4837-86ad-df76f47a27c2">
The headers are wrapped, do you know how to fix it? I'm not familiar with hugo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: Add catalog pages to docs. [iceberg-docs]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on PR #284:
URL: https://github.com/apache/iceberg-docs/pull/284#issuecomment-1772320478
I think the problem is rather that this page isn't linked in `docs/config.toml` under the main menu section: https://github.com/apache/iceberg-docs/blob/3211e6ec736b82c719e1b960cf839b3d0128066b/docs/config.toml#L66
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org