You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Benjy Weinberger (JIRA)" <ji...@apache.org> on 2012/07/16 04:11:33 UTC
[jira] [Commented] (THRIFT-1651) Support annotations on
enums/senums and their values
[ https://issues.apache.org/jira/browse/THRIFT-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414824#comment-13414824 ]
Benjy Weinberger commented on THRIFT-1651:
------------------------------------------
The patch adds support for annotations on enums and senums, and on enum values. It doesn't support annotations on senum values. Those are currently represented as strings, there is no 't_senum_value', so that would have been a bigger change than I wanted to make.
The patch also adds a test for the parser - it just runs the thrift compiler over all the *.thrift files under test/ (except for BrokenConstants.thrift, which is not supposed to parse) and verifies that they parse, regardless of whether the generators produce anything useful from that parse.
> Support annotations on enums/senums and their values
> ----------------------------------------------------
>
> Key: THRIFT-1651
> URL: https://issues.apache.org/jira/browse/THRIFT-1651
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (General)
> Reporter: Benjy Weinberger
> Priority: Minor
> Labels: annotations, compiler, enum
> Attachments: thrift-annotations-on-enums.patch
>
>
> Custom annotations are currently supported on almost all types, but not on enums/senums and their values. This issue proposes to add that support, so that all type definitions are uniform in this regard.
> This is useful, in particular, in custom code generation off thrift IDLs. For example, we want to annotate each value in an enum with a "database name" so we can match it with enum names in our database (which for various reasons are not the same as the names of the enum values).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira