You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/29 13:17:59 UTC

[GitHub] [incubator-nuttx] sebastianene07 opened a new pull request #1914: arch/sim: Make the SIGUSR1 host signal to use the NuttX irq logic

sebastianene07 opened a new pull request #1914:
URL: https://github.com/apache/incubator-nuttx/pull/1914


   ## Summary
   
   This patch updates the SIGUSR1 handling to use the NuttX interrupt logic. Remove unused sections from the sim/arch.h
   
   ## Impact
   
   None.
   
   ## Testing
   
   This has been verified on `sim/ostest`.
   
   Signed-off-by: Sebastian Ene <se...@apache.org>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] sebastianene07 commented on a change in pull request #1914: arch/sim: Make the SIGUSR1 host signal use the NuttX irq logic

Posted by GitBox <gi...@apache.org>.
sebastianene07 commented on a change in pull request #1914:
URL: https://github.com/apache/incubator-nuttx/pull/1914#discussion_r497445915



##########
File path: arch/sim/src/sim/up_simsmp.c
##########
@@ -93,6 +93,8 @@ void sched_note_cpu_pause(struct tcb_s *tcb, int cpu);
 void sched_note_cpu_resume(struct tcb_s *tcb, int cpu);
 #endif
 
+void up_enable_irq(int irq);

Review comment:
       Yes we don't need this, I will remove it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] sebastianene07 commented on a change in pull request #1914: arch/sim: Make the SIGUSR1 host signal use the NuttX irq logic

Posted by GitBox <gi...@apache.org>.
sebastianene07 commented on a change in pull request #1914:
URL: https://github.com/apache/incubator-nuttx/pull/1914#discussion_r497446987



##########
File path: arch/sim/src/sim/up_internal.h
##########
@@ -242,6 +242,7 @@ void sim_cpu0_start(void);
 void up_cpu_started(void);
 int up_cpu_paused(int cpu);
 struct tcb_s *up_this_task(void);
+int host_setcpupause_request(int irq);

Review comment:
       I updated the name to `up_cpu_set_pause_handler `




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #1914: arch/sim: Make the SIGUSR1 host signal use the NuttX irq logic

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #1914:
URL: https://github.com/apache/incubator-nuttx/pull/1914


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1914: arch/sim: Make the SIGUSR1 host signal use the NuttX irq logic

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1914:
URL: https://github.com/apache/incubator-nuttx/pull/1914#discussion_r497224582



##########
File path: arch/sim/src/sim/up_simsmp.c
##########
@@ -93,6 +93,8 @@ void sched_note_cpu_pause(struct tcb_s *tcb, int cpu);
 void sched_note_cpu_resume(struct tcb_s *tcb, int cpu);
 #endif
 
+void up_enable_irq(int irq);

Review comment:
       don't need?

##########
File path: arch/sim/src/sim/up_internal.h
##########
@@ -242,6 +242,7 @@ void sim_cpu0_start(void);
 void up_cpu_started(void);
 int up_cpu_paused(int cpu);
 struct tcb_s *up_this_task(void);
+int host_setcpupause_request(int irq);

Review comment:
       change to up_cpu_set_pause_handler?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org