Re: [PR] Add validations for the rewritten data [iceberg]

["karuppayya (via GitHub)" <gi...@apache.org>]

karuppayya commented on code in PR #9303:
URL: https://github.com/apache/iceberg/pull/9303#discussion_r1444968052


##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/SparkSizeBasedDataRewriter.java:
##########
@@ -57,7 +64,34 @@ public Set<DataFile> rewrite(List<FileScanTask> group) {
 
       doRewrite(groupId, group);
 
-      return coordinator.fetchNewFiles(table(), groupId);
+      Set<DataFile> newFiles = coordinator.fetchNewFiles(table(), groupId);
+
+      PartitionData partition = (PartitionData) group.get(0).partition();

Review Comment:
   Is it safe to assume about the type `PartitionData`, without type checking explicitly?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org