You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/09/07 01:02:22 UTC
[GitHub] [apisix] tokers commented on a change in pull request #4965: feat(proxy-mirror): support mirror requests sample_ratio
tokers commented on a change in pull request #4965:
URL: https://github.com/apache/apisix/pull/4965#discussion_r703110158
##########
File path: docs/en/latest/plugins/proxy-mirror.md
##########
@@ -29,13 +29,14 @@ The proxy-mirror plugin, which provides the ability to mirror client requests.
| Name | Type | Requirement | Default | Valid | Description |
| ---- | ------ | ----------- | ------- | ----- | --------------------------------------------------------------------------------------------------------------------------- |
-| host | string | optional | | | Specify a mirror service address, e.g. http://127.0.0.1:9797 (address needs to contain schema: http or https, not URI part) |
+| host | string | required | | | Specify a mirror service address, e.g. http://127.0.0.1:9797 (address needs to contain schema: http or https, not URI part) |
Review comment:
```suggestion
| host | string | required | | | Specify a mirror service address, e.g. http://127.0.0.1:9797 (address needs to contain scheme: http or https, and without the path part) |
```
##########
File path: docs/en/latest/plugins/proxy-mirror.md
##########
@@ -29,13 +29,14 @@ The proxy-mirror plugin, which provides the ability to mirror client requests.
| Name | Type | Requirement | Default | Valid | Description |
| ---- | ------ | ----------- | ------- | ----- | --------------------------------------------------------------------------------------------------------------------------- |
-| host | string | optional | | | Specify a mirror service address, e.g. http://127.0.0.1:9797 (address needs to contain schema: http or https, not URI part) |
+| host | string | required | | | Specify a mirror service address, e.g. http://127.0.0.1:9797 (address needs to contain schema: http or https, not URI part) |
+| sample_ratio | number | optional | 1 | [0.00001, 1] | the sample_ratio of mirror requests |
Review comment:
```suggestion
| sample_ratio | number | optional | 1 | [0.00001, 1] | the sample ratio that requests will be mirrored. |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org