You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by Guillaume Nodet <gn...@apache.org> on 2016/10/03 08:30:55 UTC

Re: [DISCUSS] Release new gogo runtime / jline bundles

I've downgraded the requirement or the gogo-runtime to java 7.
That's not really possible for the gogo-jline bundle which has a dependency
on jline requiring java 8 atm.

Given the amount of change, I think it would be better to bump the
gogo-runtime bundle version.  Given it's currently at 0.17, what should it
be then ? Bump to 1.0 ?

2016-09-28 10:52 GMT+02:00 David Bosschaert <da...@gmail.com>:

> I think it would be great to finally get the improved gogo shell released
> in Felix. Personally I don't really need Java 7 support, but it might be
> good to allow this to enable wider adoption. If we support Java 7 we might
> be able to replace the default shell in the Felix Framework download with
> this improved one. It might be harder to replace the default if it requires
> Java 8...
>
> I'm not entirely sure - what do people think, will we replace the default
> shell in the framework with this new gogo shell? And if so, will Java 8 be
> ok?
>
> Thanks,
>
> David
>
> On 28 September 2016 at 01:40, David Jencks <david_jencks@yahoo.com.
> invalid>
> wrote:
>
> > I don’t recall too well…. IIRC line requires java 8.  Does the rest of
> > gogo now also require java 8?
> >
> > thanks
> > david jencks
> >
> >
> > > On Sep 27, 2016, at 3:02 PM, Guillaume Nodet <gn...@apache.org>
> wrote:
> > >
> > > I'd like to release the big changes pending in gogo runtime and gogo
> > jline
> > > bundles.
> > > Given there are some big changes in the runtime (the jline one is a new
> > > bundle, so it does not matter so much), I'd like to give people some
> time
> > > to review the changes.
> > >
> > > I'd like to do the release next week if there's no concerns.
> > >
> > > Some of the new features from gogo runtime:
> > >  * better parser
> > >  * support for redirections
> > >  * support for jobs
> > >  * advanced parameter expansion (such as ${(GL)it/_/-})
> > > Features provided by the new gogo jline bundle (similar to the gogo
> > shell,
> > > but using jline + leveraging the new runtime features):
> > >  * better terminal support
> > >  * full line editing
> > >  * completion
> > >  * syntax highlighting
> > >  * multi line edition
> > >
> > > Note that those bundles can also be run outside osgi (jline +
> > gogo-runtime
> > > + gogo-jline).  I'm using the following command line to launch those
> from
> > > the felix/gogo directory:
> > >
> > > java -cp
> > > /Users/gnodet/.m2/repository/org/jline/jline/3.0.0.M2/
> > jline-3.0.0.M2.jar:runtime/target/org.apache.felix.gogo.
> > runtime-0.17.0-SNAPSHOT.jar:jline/target/org.apache.felix.
> > gogo.jline-0.1.0-SNAPSHOT.jar
> > > org.apache.felix.gogo.jline.Main
> > >
> > > Cheers,
> > > Guillaume Nodet
> >
> >
>



-- 
------------------------
Guillaume Nodet
------------------------
Red Hat, Open Source Integration

Email: gnodet@redhat.com
Web: http://fusesource.com
Blog: http://gnodet.blogspot.com/

Re: [DISCUSS] Release new gogo runtime / jline bundles

Posted by "Richard S. Hall" <he...@ungoverned.org>.

On 10/4/16 04:13 , Guillaume Nodet wrote:
> 2016-10-04 9:16 GMT+02:00 David Bosschaert <da...@gmail.com>:
>
>> Hi Guillaume,
>>
>> Does gogo-runtime have a dependency on gogo-jline or will it work without?
>> Just trying to understand what Java 7 users will be able to do/are missing
>> without gogo-jline...
>>
> No, the dependency is from gogo-jline to gogo-runtime. The gogo-runtime
> bundle can be used with gogo-shell or gogo-jline (they are doing the same
> thing, but differently).
> So JDK7 users can use gogo-runtime + gogo-shell, while JDK8 users can use
> gogo-runtime + gogo-jline.
>
>
>> On the version number, if the refactoring was just a change of internal
>> implementation details without any API changes then, even though there may
>> be a lot of changes version 0.17.1 would even be ok :)
>>
>> OTOH when going to version 1.0 I think we're more making a statement: "this
>> is a good, maintained release" - versions 0.x are generally considered
>> experimental I think. So I think this is a good thing to do so I would +1
>> for 1.0.
>>
> Yes, I know the usual sematics behind 0.x versions.  But I agree, at some
> point,
> it does not make sense to stay on 0.x forever.
>
> So unless somone objects, I'll go for 1.0 for both gogo-runtime and
> gogo-jline and their packages.
> I think we could also get rid of the status="provisional";
> mandatory:="status"  stuff on the packages which does not make sense
> anymore.

The only reason why that was done in the first place was because there 
was provisional OSGi API per our policy. However, if there is no longer 
OSGi API in it, then yeah it definitely doesn't make sense anymore.

-> richard

>
>> Cheers,
>>
>> David
>>
>> On 3 October 2016 at 09:30, Guillaume Nodet <gn...@apache.org> wrote:
>>
>>> I've downgraded the requirement or the gogo-runtime to java 7.
>>> That's not really possible for the gogo-jline bundle which has a
>> dependency
>>> on jline requiring java 8 atm.
>>>
>>> Given the amount of change, I think it would be better to bump the
>>> gogo-runtime bundle version.  Given it's currently at 0.17, what should
>> it
>>> be then ? Bump to 1.0 ?
>>>
>>> 2016-09-28 10:52 GMT+02:00 David Bosschaert <david.bosschaert@gmail.com
>>> :
>>>
>>>> I think it would be great to finally get the improved gogo shell
>> released
>>>> in Felix. Personally I don't really need Java 7 support, but it might
>> be
>>>> good to allow this to enable wider adoption. If we support Java 7 we
>>> might
>>>> be able to replace the default shell in the Felix Framework download
>> with
>>>> this improved one. It might be harder to replace the default if it
>>> requires
>>>> Java 8...
>>>>
>>>> I'm not entirely sure - what do people think, will we replace the
>> default
>>>> shell in the framework with this new gogo shell? And if so, will Java 8
>>> be
>>>> ok?
>>>>
>>>> Thanks,
>>>>
>>>> David
>>>>
>>>> On 28 September 2016 at 01:40, David Jencks <david_jencks@yahoo.com.
>>>> invalid>
>>>> wrote:
>>>>
>>>>> I don\u2019t recall too well\u2026. IIRC line requires java 8.  Does the rest
>> of
>>>>> gogo now also require java 8?
>>>>>
>>>>> thanks
>>>>> david jencks
>>>>>
>>>>>
>>>>>> On Sep 27, 2016, at 3:02 PM, Guillaume Nodet <gn...@apache.org>
>>>> wrote:
>>>>>> I'd like to release the big changes pending in gogo runtime and
>> gogo
>>>>> jline
>>>>>> bundles.
>>>>>> Given there are some big changes in the runtime (the jline one is a
>>> new
>>>>>> bundle, so it does not matter so much), I'd like to give people
>> some
>>>> time
>>>>>> to review the changes.
>>>>>>
>>>>>> I'd like to do the release next week if there's no concerns.
>>>>>>
>>>>>> Some of the new features from gogo runtime:
>>>>>>   * better parser
>>>>>>   * support for redirections
>>>>>>   * support for jobs
>>>>>>   * advanced parameter expansion (such as ${(GL)it/_/-})
>>>>>> Features provided by the new gogo jline bundle (similar to the gogo
>>>>> shell,
>>>>>> but using jline + leveraging the new runtime features):
>>>>>>   * better terminal support
>>>>>>   * full line editing
>>>>>>   * completion
>>>>>>   * syntax highlighting
>>>>>>   * multi line edition
>>>>>>
>>>>>> Note that those bundles can also be run outside osgi (jline +
>>>>> gogo-runtime
>>>>>> + gogo-jline).  I'm using the following command line to launch
>> those
>>>> from
>>>>>> the felix/gogo directory:
>>>>>>
>>>>>> java -cp
>>>>>> /Users/gnodet/.m2/repository/org/jline/jline/3.0.0.M2/
>>>>> jline-3.0.0.M2.jar:runtime/target/org.apache.felix.gogo.
>>>>> runtime-0.17.0-SNAPSHOT.jar:jline/target/org.apache.felix.
>>>>> gogo.jline-0.1.0-SNAPSHOT.jar
>>>>>> org.apache.felix.gogo.jline.Main
>>>>>>
>>>>>> Cheers,
>>>>>> Guillaume Nodet
>>>>>
>>>
>>>
>>> --
>>> ------------------------
>>> Guillaume Nodet
>>> ------------------------
>>> Red Hat, Open Source Integration
>>>
>>> Email: gnodet@redhat.com
>>> Web: http://fusesource.com
>>> Blog: http://gnodet.blogspot.com/
>>>
>
>


Re: [DISCUSS] Release new gogo runtime / jline bundles

Posted by Guillaume Nodet <gn...@apache.org>.
2016-10-04 9:16 GMT+02:00 David Bosschaert <da...@gmail.com>:

> Hi Guillaume,
>
> Does gogo-runtime have a dependency on gogo-jline or will it work without?
> Just trying to understand what Java 7 users will be able to do/are missing
> without gogo-jline...
>

No, the dependency is from gogo-jline to gogo-runtime. The gogo-runtime
bundle can be used with gogo-shell or gogo-jline (they are doing the same
thing, but differently).
So JDK7 users can use gogo-runtime + gogo-shell, while JDK8 users can use
gogo-runtime + gogo-jline.


>
> On the version number, if the refactoring was just a change of internal
> implementation details without any API changes then, even though there may
> be a lot of changes version 0.17.1 would even be ok :)
>
> OTOH when going to version 1.0 I think we're more making a statement: "this
> is a good, maintained release" - versions 0.x are generally considered
> experimental I think. So I think this is a good thing to do so I would +1
> for 1.0.
>

Yes, I know the usual sematics behind 0.x versions.  But I agree, at some
point,
it does not make sense to stay on 0.x forever.

So unless somone objects, I'll go for 1.0 for both gogo-runtime and
gogo-jline and their packages.
I think we could also get rid of the status="provisional";
mandatory:="status"  stuff on the packages which does not make sense
anymore.


>
> Cheers,
>
> David
>
> On 3 October 2016 at 09:30, Guillaume Nodet <gn...@apache.org> wrote:
>
> > I've downgraded the requirement or the gogo-runtime to java 7.
> > That's not really possible for the gogo-jline bundle which has a
> dependency
> > on jline requiring java 8 atm.
> >
> > Given the amount of change, I think it would be better to bump the
> > gogo-runtime bundle version.  Given it's currently at 0.17, what should
> it
> > be then ? Bump to 1.0 ?
> >
> > 2016-09-28 10:52 GMT+02:00 David Bosschaert <david.bosschaert@gmail.com
> >:
> >
> > > I think it would be great to finally get the improved gogo shell
> released
> > > in Felix. Personally I don't really need Java 7 support, but it might
> be
> > > good to allow this to enable wider adoption. If we support Java 7 we
> > might
> > > be able to replace the default shell in the Felix Framework download
> with
> > > this improved one. It might be harder to replace the default if it
> > requires
> > > Java 8...
> > >
> > > I'm not entirely sure - what do people think, will we replace the
> default
> > > shell in the framework with this new gogo shell? And if so, will Java 8
> > be
> > > ok?
> > >
> > > Thanks,
> > >
> > > David
> > >
> > > On 28 September 2016 at 01:40, David Jencks <david_jencks@yahoo.com.
> > > invalid>
> > > wrote:
> > >
> > > > I don’t recall too well…. IIRC line requires java 8.  Does the rest
> of
> > > > gogo now also require java 8?
> > > >
> > > > thanks
> > > > david jencks
> > > >
> > > >
> > > > > On Sep 27, 2016, at 3:02 PM, Guillaume Nodet <gn...@apache.org>
> > > wrote:
> > > > >
> > > > > I'd like to release the big changes pending in gogo runtime and
> gogo
> > > > jline
> > > > > bundles.
> > > > > Given there are some big changes in the runtime (the jline one is a
> > new
> > > > > bundle, so it does not matter so much), I'd like to give people
> some
> > > time
> > > > > to review the changes.
> > > > >
> > > > > I'd like to do the release next week if there's no concerns.
> > > > >
> > > > > Some of the new features from gogo runtime:
> > > > >  * better parser
> > > > >  * support for redirections
> > > > >  * support for jobs
> > > > >  * advanced parameter expansion (such as ${(GL)it/_/-})
> > > > > Features provided by the new gogo jline bundle (similar to the gogo
> > > > shell,
> > > > > but using jline + leveraging the new runtime features):
> > > > >  * better terminal support
> > > > >  * full line editing
> > > > >  * completion
> > > > >  * syntax highlighting
> > > > >  * multi line edition
> > > > >
> > > > > Note that those bundles can also be run outside osgi (jline +
> > > > gogo-runtime
> > > > > + gogo-jline).  I'm using the following command line to launch
> those
> > > from
> > > > > the felix/gogo directory:
> > > > >
> > > > > java -cp
> > > > > /Users/gnodet/.m2/repository/org/jline/jline/3.0.0.M2/
> > > > jline-3.0.0.M2.jar:runtime/target/org.apache.felix.gogo.
> > > > runtime-0.17.0-SNAPSHOT.jar:jline/target/org.apache.felix.
> > > > gogo.jline-0.1.0-SNAPSHOT.jar
> > > > > org.apache.felix.gogo.jline.Main
> > > > >
> > > > > Cheers,
> > > > > Guillaume Nodet
> > > >
> > > >
> > >
> >
> >
> >
> > --
> > ------------------------
> > Guillaume Nodet
> > ------------------------
> > Red Hat, Open Source Integration
> >
> > Email: gnodet@redhat.com
> > Web: http://fusesource.com
> > Blog: http://gnodet.blogspot.com/
> >
>



-- 
------------------------
Guillaume Nodet
------------------------
Red Hat, Open Source Integration

Email: gnodet@redhat.com
Web: http://fusesource.com
Blog: http://gnodet.blogspot.com/

Re: [DISCUSS] Release new gogo runtime / jline bundles

Posted by David Bosschaert <da...@gmail.com>.
Hi Guillaume,

Does gogo-runtime have a dependency on gogo-jline or will it work without?
Just trying to understand what Java 7 users will be able to do/are missing
without gogo-jline...

On the version number, if the refactoring was just a change of internal
implementation details without any API changes then, even though there may
be a lot of changes version 0.17.1 would even be ok :)

OTOH when going to version 1.0 I think we're more making a statement: "this
is a good, maintained release" - versions 0.x are generally considered
experimental I think. So I think this is a good thing to do so I would +1
for 1.0.

Cheers,

David

On 3 October 2016 at 09:30, Guillaume Nodet <gn...@apache.org> wrote:

> I've downgraded the requirement or the gogo-runtime to java 7.
> That's not really possible for the gogo-jline bundle which has a dependency
> on jline requiring java 8 atm.
>
> Given the amount of change, I think it would be better to bump the
> gogo-runtime bundle version.  Given it's currently at 0.17, what should it
> be then ? Bump to 1.0 ?
>
> 2016-09-28 10:52 GMT+02:00 David Bosschaert <da...@gmail.com>:
>
> > I think it would be great to finally get the improved gogo shell released
> > in Felix. Personally I don't really need Java 7 support, but it might be
> > good to allow this to enable wider adoption. If we support Java 7 we
> might
> > be able to replace the default shell in the Felix Framework download with
> > this improved one. It might be harder to replace the default if it
> requires
> > Java 8...
> >
> > I'm not entirely sure - what do people think, will we replace the default
> > shell in the framework with this new gogo shell? And if so, will Java 8
> be
> > ok?
> >
> > Thanks,
> >
> > David
> >
> > On 28 September 2016 at 01:40, David Jencks <david_jencks@yahoo.com.
> > invalid>
> > wrote:
> >
> > > I don’t recall too well…. IIRC line requires java 8.  Does the rest of
> > > gogo now also require java 8?
> > >
> > > thanks
> > > david jencks
> > >
> > >
> > > > On Sep 27, 2016, at 3:02 PM, Guillaume Nodet <gn...@apache.org>
> > wrote:
> > > >
> > > > I'd like to release the big changes pending in gogo runtime and gogo
> > > jline
> > > > bundles.
> > > > Given there are some big changes in the runtime (the jline one is a
> new
> > > > bundle, so it does not matter so much), I'd like to give people some
> > time
> > > > to review the changes.
> > > >
> > > > I'd like to do the release next week if there's no concerns.
> > > >
> > > > Some of the new features from gogo runtime:
> > > >  * better parser
> > > >  * support for redirections
> > > >  * support for jobs
> > > >  * advanced parameter expansion (such as ${(GL)it/_/-})
> > > > Features provided by the new gogo jline bundle (similar to the gogo
> > > shell,
> > > > but using jline + leveraging the new runtime features):
> > > >  * better terminal support
> > > >  * full line editing
> > > >  * completion
> > > >  * syntax highlighting
> > > >  * multi line edition
> > > >
> > > > Note that those bundles can also be run outside osgi (jline +
> > > gogo-runtime
> > > > + gogo-jline).  I'm using the following command line to launch those
> > from
> > > > the felix/gogo directory:
> > > >
> > > > java -cp
> > > > /Users/gnodet/.m2/repository/org/jline/jline/3.0.0.M2/
> > > jline-3.0.0.M2.jar:runtime/target/org.apache.felix.gogo.
> > > runtime-0.17.0-SNAPSHOT.jar:jline/target/org.apache.felix.
> > > gogo.jline-0.1.0-SNAPSHOT.jar
> > > > org.apache.felix.gogo.jline.Main
> > > >
> > > > Cheers,
> > > > Guillaume Nodet
> > >
> > >
> >
>
>
>
> --
> ------------------------
> Guillaume Nodet
> ------------------------
> Red Hat, Open Source Integration
>
> Email: gnodet@redhat.com
> Web: http://fusesource.com
> Blog: http://gnodet.blogspot.com/
>